All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] luarocks: add buildroot addon
Date: Mon, 31 Dec 2018 18:06:55 +0100	[thread overview]
Message-ID: <20181231180655.1e49b950@windsurf> (raw)
In-Reply-To: <20181219081707.1983-2-francois.perrad@gadz.org>

Hello,

On Wed, 19 Dec 2018 09:17:03 +0100, Francois Perrad wrote:

> ++   if #licenses == 1 then
> ++      f:write(ucname .. '_LICENSE_FILES = $(' .. ucname .. '_SUBDIR)/' .. licenses[1] .. '\n')
> ++   elseif #licenses > 1 then
> ++      f:write(ucname .. '_LICENSE_FILES =')
> ++      for i = 1, #licenses do
> ++         local file = licenses[i]
> ++         f:write(' \\\n    $(' .. ucname .. '_SUBDIR)/' .. file)

This is not good: it indents each line with 4 spaces, while it should
indent with one tab. Due to this, the regenerated .mk files caused
check-package to complain. I fixed the issues manually in:

  https://git.busybox.net/buildroot/commit/?id=42fa5bcbfb48f188c2c180854c0bbdefd98c32c8

But of course the Luarocks addon must be fixed to not re-introduce
similar issues. Could you cook a patch to that effect ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-31 17:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  8:17 [Buildroot] [PATCH v3] luarocks addon Francois Perrad
2018-12-19  8:17 ` [Buildroot] [PATCH v3] luarocks: add buildroot addon Francois Perrad
2018-12-31 17:06   ` Thomas Petazzoni [this message]
2018-12-19  8:17 ` [Buildroot] [PATCH v3] lua*: regeneration of *.mk files Francois Perrad
2018-12-19  8:17 ` [Buildroot] [PATCH v3] lua*: regeneration of Config.in Francois Perrad
2018-12-31 16:58   ` Thomas Petazzoni
2018-12-19  8:17 ` [Buildroot] [PATCH v3] lua*: regeneration of hash files Francois Perrad
2018-12-19  8:17 ` [Buildroot] [PATCH v3] pkg-luarocks: add per package upgrade target Francois Perrad
2018-12-31 16:57 ` [Buildroot] [PATCH v3] luarocks addon Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231180655.1e49b950@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.