* [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled
@ 2018-12-31 19:18 Darrick J. Wong
2019-01-01 23:52 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-12-31 19:18 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Use the sparse inobt record field decoder (inobt_spcrc_hfld) to decode
finobt records when sparse inodes are enabled. Otherwise, xfs_db
prints out bogus things like:
recs[1] = [startino,freecount,free]
1:[214720,16429,0xfffffffffff80000]
There can never be 16429 records in an inode btree record; instead it
should print:
recs[1] = [startino,holemask,count,freecount,free]
1:[214720,0,64,45,0xfffffffffff80000]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/type.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/db/type.c b/db/type.c
index d0234c57..f5f65042 100644
--- a/db/type.c
+++ b/db/type.c
@@ -151,7 +151,7 @@ static const typ_t __typtab_spcrc[] = {
{ TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
&xfs_symlink_buf_ops, XFS_SYMLINK_CRC_OFF },
{ TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_FINOBT, "finobt", handle_struct, inobt_crc_hfld,
+ { TYP_FINOBT, "finobt", handle_struct, inobt_spcrc_hfld,
&xfs_inobt_buf_ops, XFS_BTREE_SBLOCK_CRC_OFF },
{ TYP_NONE, NULL }
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled
2018-12-31 19:18 [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled Darrick J. Wong
@ 2019-01-01 23:52 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2019-01-01 23:52 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Mon, Dec 31, 2018 at 11:18:48AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use the sparse inobt record field decoder (inobt_spcrc_hfld) to decode
> finobt records when sparse inodes are enabled. Otherwise, xfs_db
> prints out bogus things like:
>
> recs[1] = [startino,freecount,free]
> 1:[214720,16429,0xfffffffffff80000]
>
> There can never be 16429 records in an inode btree record; instead it
> should print:
>
> recs[1] = [startino,holemask,count,freecount,free]
> 1:[214720,0,64,45,0xfffffffffff80000]
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/type.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/db/type.c b/db/type.c
> index d0234c57..f5f65042 100644
> --- a/db/type.c
> +++ b/db/type.c
> @@ -151,7 +151,7 @@ static const typ_t __typtab_spcrc[] = {
> { TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
> &xfs_symlink_buf_ops, XFS_SYMLINK_CRC_OFF },
> { TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_FINOBT, "finobt", handle_struct, inobt_crc_hfld,
> + { TYP_FINOBT, "finobt", handle_struct, inobt_spcrc_hfld,
> &xfs_inobt_buf_ops, XFS_BTREE_SBLOCK_CRC_OFF },
> { TYP_NONE, NULL }
> };
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-01 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 19:18 [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled Darrick J. Wong
2019-01-01 23:52 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.