From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/cmdline: Fix buggy strncmp(s, LITERAL,
 ss - s) construct
Date: Wed, 2 Jan 2019 11:13:45 +0100
Message-ID: <20190102101345.oqezg5mamqjikpb3@mac>
References: <1546277721-20234-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Content-Disposition: inline
In-Reply-To: <1546277721-20234-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

T24gTW9uLCBEZWMgMzEsIDIwMTggYXQgMDU6MzU6MjFQTSArMDAwMCwgQW5kcmV3IENvb3BlciB3
cm90ZToKPiBXaGVuIHRoZSBjb21tYW5kIGxpbmUgcGFyc2luZyB3YXMgdXBkYXRlZCB0byB1c2Ug
Y29uc3Qgc3RyaW5ncyBhbmQgbm8gbG9uZ2VyCj4gdG9rZW5pc2Ugd2l0aCBOVUwgY2hhcmFjdGVy
cywgc3RyaW5nIG1hdGNoZXMgY291bGQgbm8gbG9uZ2VyIGJlIG1hZGUgd2l0aAo+IHN0cmNtcCgp
Lgo+IAo+IFVuZm9ydHVuYXRlbHksIHRoZSByZXBsYWNlbWVudCB3YXMgYnVnZ3kuICBzdHJuY21w
KHMsICJvcHQiLCBzcyAtIHMpIG1hdGNoZXMKPiAibyIsICJvcCIgYW5kICJvcHQiIG9uIHRoZSBj
b21tYW5kIGxpbmUsIGFzIHNzIC0gcyBtYXkgYmUgc2hvcnRlciB0aGFuIHRoZQo+IHBhc3NlZCBs
aXRlcmFsLiAgRnVydGhlcm1vcmUsIHBhcnNlX2Jvb2woKSBpcyBhZmZlY3RlZCBieSB0aGlzLCBz
byBzdWJzdHJpbmdzCj4gc3VjaCBhcyAiZCIsICJlIiBhbmQgIm8iIGFyZSBjb25zaWRlcmVkIHZh
bGlkLCB3aXRoIHRoZSBsYXR0ZXIgYmVpbmcgYW1iaWd1b3VzCj4gYmV0d2VlbiAib24iIGFuZCAi
b2ZmIi4KPiAKPiBJbnRyb2R1Y2UgYSBuZXcgc3RyY21wLWxpa2UgZnVuY3Rpb24gZm9yIHRoZSB0
YXNrLCB3aGljaCBsb29rcyBmb3IgZXhhY3QKPiBzdHJpbmcgbWF0Y2hlcywgYnV0IGRlY2xhcmVz
IHN1Y2Nlc3Mgd2hlbiB0aGUgTlVMIG9mIHRoZSBsaXRlcmFsIG1hdGNoZXMgYQo+IGNvbW1hIG9y
IGNvbG9uIGluIHRoZSBjb21tYW5kIGxpbmUgZnJhZ21lbnQuCj4gCj4gTm8gY2hhbmdlIHRvIHRo
ZSBpbnRlbmRlZCBwYXJzaW5nIGZ1bmN0aW9uYWxpdHksIGJ1dCBmaXhlcyBjYXNlcyB3aGVyZSBh
Cj4gcGFydGlhbCBzdHJpbmcgb24gdGhlIGNvbW1hbmQgbGluZSB3aWxsIGluYWR2ZXJ0ZW50bHkg
dHJpZ2dlciBvcHRpb25zLgo+IAo+IEEgZmV3IGFyZWFzIHdlcmUgbW9yZSB0aGFuIGp1c3QgYSB0
cml2aWFsIGNoYW5nZToKPiAKPiAgKiBmZHRfYWRkX3VlZmlfbm9kZXMoKSwgd2hpbGUgbm90IGNv
bW1hbmQgbGluZSBwYXJzaW5nLCBoYWQgdGhlIHNhbWUgYnJva2VuCj4gICAgc3RybmNtcCgpIHBh
dHRlcm4uICBBcyBhIGZpeCwgcGVyZm9ybSBhbiBleHBsaWNpdCBsZW5ndGggY2hlY2sgZmlyc3Qu
Cj4gICogcGFyc2VfaXJxX3ZlY3Rvcl9tYXBfcGFyYW0oKSBnYWluZWQgc29tZSBzdHlsZSBjb3Jy
ZWN0aW9ucy4KPiAgKiBwYXJzZV92cG11X3BhcmFtcygpIHdhcyByZXdyaXR0ZW4gdG8gdXNlIHRo
ZSBub3JtYWwgbGlzdC1vZi1vcHRpb25zIGZvcm0sCj4gICAgcmF0aGVyIHRoYW4ganVzdCBmaXhp
bmcgdXAgcGFyc2VfdnBtdV9wYXJhbSgpIGFuZCBsZWF2aW5nIHRoZSBwYXJzaW5nIGJlaW5nCj4g
ICAgaGFyZCB0byBmb2xsb3cuCj4gICogSW5zdGVhZCBvZiBtYWtpbmcgdGhlIHRyaXZpYWwgZml4
IG9mIGFkZGluZyBhbiBleHBsaWNpdCBsZW5ndGggY2hlY2sgaW4KPiAgICBwYXJzZV9ib29sKCks
IHVzZSB0aGUgbGVuZ3RoIHRvIHNlbGVjdCB3aGljaCB0b2tlbiB0byB3ZSBzZWFyY2ggZm9yLCB3
aGljaAo+ICAgIGlzIG1vcmUgZWZmaWNpZW50IHRoYW4gdGhlIHByZXZpb3VzIGxpbmVhciBzZWFy
Y2ggb3ZlciBhbGwgcG9zc2libGUgdG9rZW5zLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD
b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gLS0tCj4gQ0M6IEphbiBCZXVsaWNo
IDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4K
PiBDQzogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4gQ0M6IFN0ZWZh
bm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiBDQzogSnVsaWVuIEdyYWxs
IDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiAKPiBTcGxpdCBvdXQgb2YgdGhlIGRvbTAgZml4IHNl
cmllcy4gIFRoaXMgbmVlZHMgYmFja3BvcnRpbmcgdG8gNC45IGFuZCBsYXRlciwKPiBhbmQgdG8g
dGhlIHNlY3VyaXR5IHRyZWVzLCBhcyB0aGlzIGJ1ZyBoYXMgYmVlbiBiYWNrcG9ydGVkIGluIHNl
Y3VyaXR5IGZpeGVzLgo+IAo+IFRoaXMgcGF0Y2ggaXMgbW9yZSBlYXNpbHkgcmV2aWV3ZWQgd2l0
aCBgZ2l0IGRpZmYgLS1jb2xvci13b3Jkc2Agd2hpY2gKPiBoaWdobGlnaHRzIHRoYXQgaXQgaXMg
YSBzdHJhaWdodCBmdW5jdGlvbiB0cmFuc2Zvcm1hdGlvbiBpbiBtb3N0IGNhc2VzLgo+IAo+IFRo
ZSBwc3I9IG9wdGlvbiBpcyBhIGNvbXBsZXRlIHBhaW4sIGFuZCB1bmxpa2UgYWxsIHNpbWlsYXIg
b3B0aW9ucyBpbiBYZW4uCj4gSSd2ZSBoYWxmIGEgbWluZCB0byByZXdyaXRlIGl0IGZyb20gc2Ny
YXRjaCwgc2VlaW5nIGFzIHRoZSBvcHRpb24gaXNuJ3QKPiBlbmFibGVkIGJ5IGRlZmF1bHQuCj4g
LS0tCj4gK2ludCBjbWRsaW5lX3N0cmNtcChjb25zdCBjaGFyICpmcmFnLCBjb25zdCBjaGFyICpu
YW1lKQo+ICt7Cj4gKyAgICB3aGlsZSAoIDEgKQo+ICsgICAgewo+ICsgICAgICAgIGludCByZXMg
PSAoKmZyYWcgLSAqbmFtZSk7Cj4gKwo+ICsgICAgICAgIGlmICggcmVzIHx8ICpuYW1lID09ICdc
MCcgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgLyoKPiArICAgICAgICAgICAgICogTlVM
IGluICduYW1lJyBtYXRjaGluZyBhIGNvbW1hIG9yIGNvbG9uIGluICdmcmFnJyBpbXBsaWVzCj4g
KyAgICAgICAgICAgICAqIHN1Y2Nlc3MuCj4gKyAgICAgICAgICAgICAqLwo+ICsgICAgICAgICAg
ICBpZiAoICpuYW1lID09ICdcMCcgJiYgKCpmcmFnID09ICcsJyB8fCAqZnJhZyA9PSAnOicpICkK
PiArICAgICAgICAgICAgICAgIHJlcyA9IDA7Cj4gKwo+ICsgICAgICAgICAgICByZXR1cm4gcmVz
Owo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgZnJhZysrOwo+ICsgICAgICAgIG5hbWUrKzsK
PiArICAgIH0KPiArfQoKVGhlIHByZXZpb3VzIGZ1bmN0aW9uIHdvdWxkIGdldCB0aGUgbWF4IGxl
bmd0aCBvZiB0aGUgZnJhZyBhcmd1bWVudCwKd2hpY2ggSSB0aGluayB3YXMgdXNlZnVsLiBJZiB0
aGUgbGVuZ3RoIG9mIG5hbWUgPiBmcmFnIHlvdSBjb3VsZCBlbmQKdXAgYWNjZXNzaW5nIGFuIHVu
bWFwcGVkIGFkZHJlc3MgQUZBSUNULiBPciBhdCBsZWFzdCAqZnJhZyA9PSAnXDAnCnNob3VsZCBh
bHNvIGJlIHRha2VuIGludG8gYWNjb3VudCBpZiBpdCdzIGd1YXJhbnRlZWQgdGhhdCBmcmFnIG11
c3QKYWx3YXlzIGhhdmUgYW4gZW5kaW5nIE5VTC4KCkkgd291bGQgYWxzbyBjb25zaWRlciBhZGRp
bmcgX19hdHRyaWJ1dGVfXyAoKGZvcm1hdF9hcmcgKDIpKSk7IHRvIHRoZQpwcm90b3R5cGUsIHNv
IHRoYXQgdGhlIG5hbWUgYXJndW1lbnQgaXMgYWx3YXlzIGNoZWNrZWQgdG8gYmUgYQpsaXRlcmFs
LCBhcyBpcyB0aGUgY3VycmVudCB1c2FnZS4KClRoYW5rcywgUm9nZXIuCgpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0
Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu
b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs