From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct Date: Wed, 2 Jan 2019 13:25:41 +0100 Message-ID: <20190102122541.u5cssvuub3oaxfmg@mac> References: <1546277721-20234-1-git-send-email-andrew.cooper3@citrix.com> <20190102101345.oqezg5mamqjikpb3@mac> <513e77bf-619d-a05c-86c7-70d87e6cba35@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <513e77bf-619d-a05c-86c7-70d87e6cba35@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , Wei Liu , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKYW4gMDIsIDIwMTkgYXQgMTI6MTg6MjdQTSArMDAwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAwMi8wMS8yMDE5IDEwOjEzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOgo+ID4g T24gTW9uLCBEZWMgMzEsIDIwMTggYXQgMDU6MzU6MjFQTSArMDAwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiA+PiBXaGVuIHRoZSBjb21tYW5kIGxpbmUgcGFyc2luZyB3YXMgdXBkYXRlZCB0byB1 c2UgY29uc3Qgc3RyaW5ncyBhbmQgbm8gbG9uZ2VyCj4gPj4gdG9rZW5pc2Ugd2l0aCBOVUwgY2hh cmFjdGVycywgc3RyaW5nIG1hdGNoZXMgY291bGQgbm8gbG9uZ2VyIGJlIG1hZGUgd2l0aAo+ID4+ IHN0cmNtcCgpLgo+ID4+Cj4gPj4gVW5mb3J0dW5hdGVseSwgdGhlIHJlcGxhY2VtZW50IHdhcyBi dWdneS4gIHN0cm5jbXAocywgIm9wdCIsIHNzIC0gcykgbWF0Y2hlcwo+ID4+ICJvIiwgIm9wIiBh bmQgIm9wdCIgb24gdGhlIGNvbW1hbmQgbGluZSwgYXMgc3MgLSBzIG1heSBiZSBzaG9ydGVyIHRo YW4gdGhlCj4gPj4gcGFzc2VkIGxpdGVyYWwuICBGdXJ0aGVybW9yZSwgcGFyc2VfYm9vbCgpIGlz IGFmZmVjdGVkIGJ5IHRoaXMsIHNvIHN1YnN0cmluZ3MKPiA+PiBzdWNoIGFzICJkIiwgImUiIGFu ZCAibyIgYXJlIGNvbnNpZGVyZWQgdmFsaWQsIHdpdGggdGhlIGxhdHRlciBiZWluZyBhbWJpZ3Vv dXMKPiA+PiBiZXR3ZWVuICJvbiIgYW5kICJvZmYiLgo+ID4+Cj4gPj4gSW50cm9kdWNlIGEgbmV3 IHN0cmNtcC1saWtlIGZ1bmN0aW9uIGZvciB0aGUgdGFzaywgd2hpY2ggbG9va3MgZm9yIGV4YWN0 Cj4gPj4gc3RyaW5nIG1hdGNoZXMsIGJ1dCBkZWNsYXJlcyBzdWNjZXNzIHdoZW4gdGhlIE5VTCBv ZiB0aGUgbGl0ZXJhbCBtYXRjaGVzIGEKPiA+PiBjb21tYSBvciBjb2xvbiBpbiB0aGUgY29tbWFu ZCBsaW5lIGZyYWdtZW50Lgo+ID4+Cj4gPj4gTm8gY2hhbmdlIHRvIHRoZSBpbnRlbmRlZCBwYXJz aW5nIGZ1bmN0aW9uYWxpdHksIGJ1dCBmaXhlcyBjYXNlcyB3aGVyZSBhCj4gPj4gcGFydGlhbCBz dHJpbmcgb24gdGhlIGNvbW1hbmQgbGluZSB3aWxsIGluYWR2ZXJ0ZW50bHkgdHJpZ2dlciBvcHRp b25zLgo+ID4+Cj4gPj4gQSBmZXcgYXJlYXMgd2VyZSBtb3JlIHRoYW4ganVzdCBhIHRyaXZpYWwg Y2hhbmdlOgo+ID4+Cj4gPj4gICogZmR0X2FkZF91ZWZpX25vZGVzKCksIHdoaWxlIG5vdCBjb21t YW5kIGxpbmUgcGFyc2luZywgaGFkIHRoZSBzYW1lIGJyb2tlbgo+ID4+ICAgIHN0cm5jbXAoKSBw YXR0ZXJuLiAgQXMgYSBmaXgsIHBlcmZvcm0gYW4gZXhwbGljaXQgbGVuZ3RoIGNoZWNrIGZpcnN0 Lgo+ID4+ICAqIHBhcnNlX2lycV92ZWN0b3JfbWFwX3BhcmFtKCkgZ2FpbmVkIHNvbWUgc3R5bGUg Y29ycmVjdGlvbnMuCj4gPj4gICogcGFyc2VfdnBtdV9wYXJhbXMoKSB3YXMgcmV3cml0dGVuIHRv IHVzZSB0aGUgbm9ybWFsIGxpc3Qtb2Ytb3B0aW9ucyBmb3JtLAo+ID4+ICAgIHJhdGhlciB0aGFu IGp1c3QgZml4aW5nIHVwIHBhcnNlX3ZwbXVfcGFyYW0oKSBhbmQgbGVhdmluZyB0aGUgcGFyc2lu ZyBiZWluZwo+ID4+ICAgIGhhcmQgdG8gZm9sbG93Lgo+ID4+ICAqIEluc3RlYWQgb2YgbWFraW5n IHRoZSB0cml2aWFsIGZpeCBvZiBhZGRpbmcgYW4gZXhwbGljaXQgbGVuZ3RoIGNoZWNrIGluCj4g Pj4gICAgcGFyc2VfYm9vbCgpLCB1c2UgdGhlIGxlbmd0aCB0byBzZWxlY3Qgd2hpY2ggdG9rZW4g dG8gd2Ugc2VhcmNoIGZvciwgd2hpY2gKPiA+PiAgICBpcyBtb3JlIGVmZmljaWVudCB0aGFuIHRo ZSBwcmV2aW91cyBsaW5lYXIgc2VhcmNoIG92ZXIgYWxsIHBvc3NpYmxlIHRva2Vucy4KPiA+Pgo+ ID4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j b20+Cj4gPj4gLS0tCj4gPj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiA+ PiBDQzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4KPiA+PiBDQzogUm9nZXIgUGF1IE1v bm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4gPj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8 c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiA+PiBDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3Jh bGxAYXJtLmNvbT4KPiA+Pgo+ID4+IFNwbGl0IG91dCBvZiB0aGUgZG9tMCBmaXggc2VyaWVzLiAg VGhpcyBuZWVkcyBiYWNrcG9ydGluZyB0byA0LjkgYW5kIGxhdGVyLAo+ID4+IGFuZCB0byB0aGUg c2VjdXJpdHkgdHJlZXMsIGFzIHRoaXMgYnVnIGhhcyBiZWVuIGJhY2twb3J0ZWQgaW4gc2VjdXJp dHkgZml4ZXMuCj4gPj4KPiA+PiBUaGlzIHBhdGNoIGlzIG1vcmUgZWFzaWx5IHJldmlld2VkIHdp dGggYGdpdCBkaWZmIC0tY29sb3Itd29yZHNgIHdoaWNoCj4gPj4gaGlnaGxpZ2h0cyB0aGF0IGl0 IGlzIGEgc3RyYWlnaHQgZnVuY3Rpb24gdHJhbnNmb3JtYXRpb24gaW4gbW9zdCBjYXNlcy4KPiA+ Pgo+ID4+IFRoZSBwc3I9IG9wdGlvbiBpcyBhIGNvbXBsZXRlIHBhaW4sIGFuZCB1bmxpa2UgYWxs IHNpbWlsYXIgb3B0aW9ucyBpbiBYZW4uCj4gPj4gSSd2ZSBoYWxmIGEgbWluZCB0byByZXdyaXRl IGl0IGZyb20gc2NyYXRjaCwgc2VlaW5nIGFzIHRoZSBvcHRpb24gaXNuJ3QKPiA+PiBlbmFibGVk IGJ5IGRlZmF1bHQuCj4gPj4gLS0tCj4gPj4gK2ludCBjbWRsaW5lX3N0cmNtcChjb25zdCBjaGFy ICpmcmFnLCBjb25zdCBjaGFyICpuYW1lKQo+ID4+ICt7Cj4gPj4gKyAgICB3aGlsZSAoIDEgKQo+ ID4+ICsgICAgewo+ID4+ICsgICAgICAgIGludCByZXMgPSAoKmZyYWcgLSAqbmFtZSk7Cj4gPj4g Kwo+ID4+ICsgICAgICAgIGlmICggcmVzIHx8ICpuYW1lID09ICdcMCcgKQo+ID4+ICsgICAgICAg IHsKPiA+PiArICAgICAgICAgICAgLyoKPiA+PiArICAgICAgICAgICAgICogTlVMIGluICduYW1l JyBtYXRjaGluZyBhIGNvbW1hIG9yIGNvbG9uIGluICdmcmFnJyBpbXBsaWVzCj4gPj4gKyAgICAg ICAgICAgICAqIHN1Y2Nlc3MuCj4gPj4gKyAgICAgICAgICAgICAqLwo+ID4+ICsgICAgICAgICAg ICBpZiAoICpuYW1lID09ICdcMCcgJiYgKCpmcmFnID09ICcsJyB8fCAqZnJhZyA9PSAnOicpICkK PiA+PiArICAgICAgICAgICAgICAgIHJlcyA9IDA7Cj4gPj4gKwo+ID4+ICsgICAgICAgICAgICBy ZXR1cm4gcmVzOwo+ID4+ICsgICAgICAgIH0KPiA+PiArCj4gPj4gKyAgICAgICAgZnJhZysrOwo+ ID4+ICsgICAgICAgIG5hbWUrKzsKPiA+PiArICAgIH0KPiA+PiArfQo+ID4gVGhlIHByZXZpb3Vz IGZ1bmN0aW9uIHdvdWxkIGdldCB0aGUgbWF4IGxlbmd0aCBvZiB0aGUgZnJhZyBhcmd1bWVudCwK PiA+IHdoaWNoIEkgdGhpbmsgd2FzIHVzZWZ1bC4gSWYgdGhlIGxlbmd0aCBvZiBuYW1lID4gZnJh ZyB5b3UgY291bGQgZW5kCj4gPiB1cCBhY2Nlc3NpbmcgYW4gdW5tYXBwZWQgYWRkcmVzcyBBRkFJ Q1QuIE9yIGF0IGxlYXN0ICpmcmFnID09ICdcMCcKPiA+IHNob3VsZCBhbHNvIGJlIHRha2VuIGlu dG8gYWNjb3VudCBpZiBpdCdzIGd1YXJhbnRlZWQgdGhhdCBmcmFnIG11c3QKPiA+IGFsd2F5cyBo YXZlIGFuIGVuZGluZyBOVUwuCj4gCj4gSXQgaXMgY29tcGxldGVseSB1bnJlYXNvbmFibGUgdG8g cGFzcyBhIG5vbi10ZXJtaW5hdGVkIHN0cmluZyBpbnRvCj4gc3RyaW5nIHBhcnNpbmcgZnVuY3Rp b25zLCBhbmQgYSBsb3Qgb2YgdGhlIHBhcnNpbmcgY29kZSB3aWxsIGV4cGxvZGUgaWYKPiB0aGlz IGV4cGVjdGF0aW9uIGlzIHZpb2xhdGVkLgo+IAo+IFJlbWVtYmVyIHRoYXQgYmVmb3JlIHRoZSBj b25zdCBwYXJzaW5nIHdhcyBpbnRyb2R1Y2VkICg0LjkgaWlyYyksIGFsbAo+IHBhcnNpbmcgd2Vu dCB3aXRob3V0IGEgbWF4IGxlbmd0aCwgYW5kIHJlc29sdmluZyB0aGF0IGlzIHBhcnQgb2YgdGhl IGJ1Z2ZpeC4KCkJ1dCBzaG91bGRuJ3QgeW91IGNoZWNrIGZvciAqZnJhZyA9PSBOVUwgaW4gb3Jk ZXIgdG8gYXZvaWQgb3ZlcnJ1bnM/Cgo+ID4gSSB3b3VsZCBhbHNvIGNvbnNpZGVyIGFkZGluZyBf X2F0dHJpYnV0ZV9fICgoZm9ybWF0X2FyZyAoMikpKTsgdG8gdGhlCj4gPiBwcm90b3R5cGUsIHNv IHRoYXQgdGhlIG5hbWUgYXJndW1lbnQgaXMgYWx3YXlzIGNoZWNrZWQgdG8gYmUgYQo+ID4gbGl0 ZXJhbCwgYXMgaXMgdGhlIGN1cnJlbnQgdXNhZ2UuCj4gCj4gVGhhdCB3b3VsZCBmYWxzZWx5IHBy b2hpYml0IGxvb2tpbmcgZm9yIGEgc3RyaW5nIHdpdGggYSBsaXRlcmFsICUgaW4gaXQuCj4gCj4g RnVydGhlcm1vcmUsIHNlZSAiW1BBVENIIDMvOV0geDg2L2NwdWlkOiBFeHRlbmQgdGhlIGNwdWlk PSBjb21tYW5kIGxpbmUKPiBvcHRpb24gdG8gc3VwcG9ydCBhbGwgbmFtZWQgZmVhdHVyZXMiIHdo aWNoIHdhcyB0aGUgb3JpZ2luIG9mIHRoaXMKPiBmdW5jdGlvbiwgYW5kIGEgdXNlY2FzZSB3aGVy ZSBpdCBkZWZpbml0ZWx5IHdvbid0IGhhdmUgYSBzdHJpbmcgbGl0ZXJhbC4KCk9oLCBkaWRuJ3Qg a25vdyBhYm91dCB0aGlzIGNhc2UuIElmIHRoZSBwbGFuIGlzIHRvIHVzZSBpdCB3aXRob3V0Cmxp dGVyYWxzIHRoZW4gdGhlIGNvbW1lbnQgaXMgbW9vdC4KClRoYW5rcywgUm9nZXIuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs