From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf v3 0/9] bpf fix to prevent oob under speculation Date: Wed, 2 Jan 2019 16:08:26 -0800 Message-ID: <20190103000824.ph4kioreaylgvge3@ast-mbp.dhcp.thefacebook.com> References: <20190102235835.3311-1-daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ast@kernel.org, jannh@google.com, davem@davemloft.net, jakub.kicinski@netronome.com, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:46655 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfACAI3 (ORCPT ); Wed, 2 Jan 2019 19:08:29 -0500 Received: by mail-pf1-f195.google.com with SMTP id c73so15844629pfe.13 for ; Wed, 02 Jan 2019 16:08:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190102235835.3311-1-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 03, 2019 at 12:58:26AM +0100, Daniel Borkmann wrote: > This set fixes an out of bounds case under speculative execution > by implementing masking of pointer alu into the verifier. For > details please see the individual patches. > > Thanks! > > v2 -> v3: > - 8/9: change states_equal condition into old->speculative && > !cur->speculative, thanks Jakub! > - 8/9: remove incorrect speculative state test in > propagate_liveness(), thanks Jakub! > v1 -> v2: > - Typo fixes in commit msg and a comment, thanks David! Applied, Thanks