From: Matthew Wilcox <willy@infradead.org>
To: Jerome Glisse <jglisse@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Jan Kara" <jack@suse.cz>
Subject: Re: [PATCH] Initialise mmu_notifier_range correctly
Date: Thu, 3 Jan 2019 06:36:47 -0800 [thread overview]
Message-ID: <20190103143647.GP6310@bombadil.infradead.org> (raw)
In-Reply-To: <20190103143116.GB3395@redhat.com>
On Thu, Jan 03, 2019 at 09:31:16AM -0500, Jerome Glisse wrote:
> On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote:
> >
> > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range
> > incorrectly.
> >
> > Signed-off-by: Matthew Wilcox <willy@infradead.org>
> > Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for invalidate_range_start/end calls v2")
> > Tested-by: Dave Chinner <dchinner@redhat.com>
>
> Actually now that i have read the code again this is not ok to
> do so. The caller of follow_pte_pmd() will call range_init and
> follow pmd will only update the range address. So existing code
> is ok.
The only caller of follow_pte_pmd() does not call range_init() because it
doesn't know the address. That's the point of follow_pte_pmd().
> I know this is kind of ugly but i do not see a way around that
> uglyness.
You wrote the code ...
next prev parent reply other threads:[~2019-01-03 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 0:21 [PATCH] Initialise mmu_notifier_range correctly Matthew Wilcox
2019-01-03 1:56 ` Jerome Glisse
2019-01-03 1:56 ` Jerome Glisse
2019-01-03 3:32 ` John Hubbard
2019-01-03 4:18 ` Matthew Wilcox
2019-01-03 14:29 ` Jerome Glisse
2019-01-03 14:39 ` Matthew Wilcox
2019-01-03 14:39 ` Matthew Wilcox
2019-01-03 14:59 ` Jerome Glisse
2019-01-03 14:59 ` Jerome Glisse
2019-01-03 14:31 ` Jerome Glisse
2019-01-03 14:36 ` Matthew Wilcox [this message]
2019-01-03 14:43 ` Matthew Wilcox
2019-01-03 15:05 ` Jerome Glisse
2019-01-03 15:05 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103143647.GP6310@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=christian.koenig@amd.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.