All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: <mazziesaccount@gmail.com>, <broonie@kernel.org>,
	<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
	<geert@linux-m68k.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings
Date: Thu, 3 Jan 2019 17:27:38 +0000	[thread overview]
Message-ID: <20190103172738.GQ16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181227084443.GA23991@localhost.localdomain>

On Thu, Dec 27, 2018 at 10:44:43AM +0200, Matti Vaittinen wrote:
> Do not return error if irq-type setting is requested for
> controlloer which does not support this. This is how
> regmap-irq has previously handled the undupported type
> settings and existing drivers seem to be upset if failure
> is now reported.
> 
> Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add level-irq support")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> 
> Geert reported that 1c2928e3e321 breaks da9063-rtc on the Renesas
> Koelsch board:
> 
> https://lore.kernel.org/lkml/20181227075648.GB2461@localhost.localdomain/T/#m194616cc88d7b4c2a78f7ce07907608fdb64a092
> 
> Geert, do you know if anyone vould to test this?
> 

Bit late since its already been applied but this patch fixes the
issues I had.

Thanks,
Charles

      parent reply	other threads:[~2019-01-03 17:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27  8:44 [PATCH] regmap: regmap-irq: silently ignore unsupported type settings Matti Vaittinen
2018-12-29 11:13 ` Geert Uytterhoeven
2018-12-31 19:14   ` Mark Brown
2019-01-01 17:36     ` Geert Uytterhoeven
2019-01-02 15:31       ` Steve Twiss
2019-01-04 15:47         ` Geert Uytterhoeven
2019-01-07 18:52           ` Steve Twiss
2019-01-08 10:21   ` Steve Twiss
2019-01-03 17:27 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103172738.GQ16508@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.