From: Rob Herring <robh@kernel.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/2] dt-bindings: input: Update documentation for clps711x-keypad
Date: Thu, 3 Jan 2019 14:59:25 -0600 [thread overview]
Message-ID: <20190103205925.GA7342@bogus> (raw)
In-Reply-To: <20181222155520.8156-1-shc_work@mail.ru>
On Sat, Dec 22, 2018 at 06:55:20PM +0300, Alexander Shiyan wrote:
> Since the driver switched to using the syscon_regmap_lookup_by_phandle()
> function, we need to specify the phandle for the driver. This patch
> updates the driver binding documentation for these changes.
That's not a backwards compatible change. Is that okay for all users of
this platform(s)? If so, say why.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> Documentation/devicetree/bindings/input/clps711x-keypad.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/clps711x-keypad.txt b/Documentation/devicetree/bindings/input/clps711x-keypad.txt
> index 3eed881..aebedc3 100644
> --- a/Documentation/devicetree/bindings/input/clps711x-keypad.txt
> +++ b/Documentation/devicetree/bindings/input/clps711x-keypad.txt
> @@ -6,6 +6,7 @@ Required Properties:
> - poll-interval: Poll interval time in milliseconds.
> - linux,keymap: The definition can be found at
> bindings/input/matrix-keymap.txt.
> +- syscon: Phandle that points to the CPU syscon1 node.
What does this provide? If the keypad registers are a sub-block of the
syscon1, then you should make this node a child node.
>
> Optional Properties:
> - autorepeat: Enable autorepeat feature.
> @@ -17,6 +18,7 @@ Example:
> poll-interval = <120>;
> row-gpios = <&porta 0 0>,
> <&porta 1 0>;
> + syscon = <&syscon1>;
>
> linux,keymap = <
> MATRIX_KEY(0, 0, KEY_UP)
> --
> 2.10.2
>
next prev parent reply other threads:[~2019-01-03 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 15:55 [PATCH 2/2] dt-bindings: input: Update documentation for clps711x-keypad Alexander Shiyan
2019-01-03 20:59 ` Rob Herring [this message]
2019-01-16 12:26 ` Alexander Shiyan
2019-01-21 16:25 ` Rob Herring
2019-01-22 7:54 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103205925.GA7342@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.