From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:41680 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726074AbfADJzY (ORCPT ); Fri, 4 Jan 2019 04:55:24 -0500 Date: Fri, 4 Jan 2019 10:55:23 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , Matthew Bobrowski , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 11/15] fanotify: use vfs_get_fsid() helper instead of vfs_statfs() Message-ID: <20190104095523.GG22409@quack2.suse.cz> References: <20181202113826.32133-1-amir73il@gmail.com> <20181202113826.32133-12-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181202113826.32133-12-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun 02-12-18 13:38:22, Amir Goldstein wrote: > This is a cleanup that doesn't change any logic. > > Signed-off-by: Amir Goldstein > --- > fs/notify/fanotify/fanotify_user.c | 25 ++++++++++--------------- > 1 file changed, 10 insertions(+), 15 deletions(-) > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > index b69a7c23a765..8ecd9db8931c 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -855,35 +855,31 @@ SYSCALL_DEFINE2(fanotify_init, unsigned int, flags, unsigned int, event_f_flags) > } > > /* Check if filesystem can encode a unique fid */ > -static int fanotify_test_fid(struct path *path, struct kstatfs *stat) > +static int fanotify_test_fid(struct path *path, __kernel_fsid_t *fsid) > { Ah OK, here you do what I've suggested. I guess no need to redo this then. Honza -- Jan Kara SUSE Labs, CR