All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/4] xen/dom0: Improve documentation for dom0= and dom0-iommu=
Date: Fri, 4 Jan 2019 13:15:28 +0100	[thread overview]
Message-ID: <20190104121528.kgg33fma77hdzqrz@mac.bytemobile.com> (raw)
In-Reply-To: <1546269383-32166-2-git-send-email-andrew.cooper3@citrix.com>

On Mon, Dec 31, 2018 at 03:16:20PM +0000, Andrew Cooper wrote:
> +Controls for the dom0 IOMMU setup.
> +
> +*   The `passthrough` boolean controls whether IOMMU translation functionality
> +    is disabled for devices in dom0 (`passthrough=1`) or whether the IOMMU is
> +    used to ensure that dom0 can only DMA to its permitted areas of RAM
> +    (`passthrough=0`).
> +
> +    This option is only applicable to x86 PV dom0's, and defaults to false.
> +
> +    Some older Intel VT-d hardware isn't capable of disabling translation
> +    functionality on a per-device basis, and will cause this option to be
> +    ignored and assumed to be 0.  Similar behaviour on such systems is only
> +    available by fully disabling all IOMMUs.
> +
> +    This option is hardwired to false for x86 PVH dom0's (where a non-identity
> +    transform is required for dom0 to function), and is ignored for ARM.
> +
> +*   The `strict` boolean is applicable to x86 PV dom0's only and defaults to
> +    false.  It controls whether dom0 can have IOMMU mappings for all domain

I would remove 'domain' from the end of this line.

With or without that:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-01-04 12:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-31 15:16 [PATCH v2 0/4] Functional and documentation improvements to dom0 setup Andrew Cooper
2018-12-31 15:16 ` [PATCH v2 1/4] xen/dom0: Improve documentation for dom0= and dom0-iommu= Andrew Cooper
2019-01-04 12:15   ` Roger Pau Monné [this message]
2018-12-31 15:16 ` [PATCH v2 2/4] x86/dom0: Improve dom0= useability Andrew Cooper
2019-01-04 12:17   ` Roger Pau Monné
2018-12-31 15:16 ` [PATCH v2 3/4] xen/dom0: Drop iommu_hwdom_inclusive entirely Andrew Cooper
2019-01-04 12:33   ` Roger Pau Monné
2019-01-04 12:46     ` Andrew Cooper
2019-01-04 12:54       ` Roger Pau Monné
2019-01-04 14:03   ` Roger Pau Monné
2018-12-31 15:16 ` [PATCH v2 4/4] xen/dom0: Add a dom0-iommu=none option Andrew Cooper
2019-01-04 12:38   ` Roger Pau Monné
2018-12-31 17:51 ` [PATCH v2 0/4] Functional and documentation improvements to dom0 setup Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104121528.kgg33fma77hdzqrz@mac.bytemobile.com \
    --to=roger.pau@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.