From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 635CD1C0C88 for ; Mon, 7 Jan 2019 10:52:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 601F6853C5 for ; Mon, 7 Jan 2019 10:52:19 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bEOMGMe4yTeS for ; Mon, 7 Jan 2019 10:52:17 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6EB3584C3C for ; Mon, 7 Jan 2019 10:52:17 +0000 (UTC) Date: Mon, 7 Jan 2019 11:52:14 +0100 From: Greg KH Subject: Re: rtl8192e: need help with variable naming convention Message-ID: <20190107105214.GA31559@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Himadri Pandya Cc: driverdev-devel@linuxdriverproject.org On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote: > Hello, > > I'm getting started with device drivers. And as a starter, I'm working on > some clean-up patches. I'm particularly targeting to rename a structure > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "Avoid > CamelCase". According to the coding style, it should be converted to > "channel_plan". But the code contains a function argument with the same > name "channel_plan". Should I then rename the array to something like > "channel_name_"? I'm sorry for asking such a silly question. But I want to > know if renaming it in such a ways fits in the convention before I make the > change. A structure name is different from a function name, so odds are you can just do this with no problems. Try it and find out! greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel