From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 040311C1604 for ; Mon, 7 Jan 2019 13:04:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 01CBD85933 for ; Mon, 7 Jan 2019 13:04:14 +0000 (UTC) Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G+WycN+awmLx for ; Mon, 7 Jan 2019 13:04:13 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by hemlock.osuosl.org (Postfix) with ESMTPS id 52CE585803 for ; Mon, 7 Jan 2019 13:04:13 +0000 (UTC) Date: Mon, 7 Jan 2019 16:03:14 +0300 From: Dan Carpenter Subject: Re: rtl8192e: need help with variable naming convention Message-ID: <20190107130314.GD3200@kadam> References: <20190107105214.GA31559@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190107105214.GA31559@kroah.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Greg KH Cc: driverdev-devel@linuxdriverproject.org On Mon, Jan 07, 2019 at 11:52:14AM +0100, Greg KH wrote: > On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote: > > Hello, > > > > I'm getting started with device drivers. And as a starter, I'm working on > > some clean-up patches. I'm particularly targeting to rename a structure > > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "Avoid > > CamelCase". According to the coding style, it should be converted to > > "channel_plan". But the code contains a function argument with the same > > name "channel_plan". Should I then rename the array to something like > > "channel_name_"? Ending a name with an underscore is quite ugly. Feel free to get more creative with the naming scheme. Rethink things as much as you can, don't assume the original code is something to copy. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel