From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Rini <trini@konsulko.com>
Date: Wed, 9 Jan 2019 07:11:35 -0500
Subject: [U-Boot] [U-Boot,
 2/2] mmc: bring back partition init for non-DM MMC drivers
In-Reply-To: <ca2ae07f-a7b0-2653-04a0-264e792c5a0b@arm.com>
References: <20181217100545.28369-3-andre.przywara@arm.com>
 <20190109034452.GA8382@bill-the-cat>
 <ca2ae07f-a7b0-2653-04a0-264e792c5a0b@arm.com>
Message-ID: <20190109121135.GY5463@bill-the-cat>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

On Wed, Jan 09, 2019 at 09:03:19AM +0000, Andr=C3=A9 Przywara wrote:
> On 09/01/2019 03:44, Tom Rini wrote:
> > On Mon, Dec 17, 2018 at 10:05:45AM +0000, Andre Przywara wrote:
> >=20
> >> Commit d0851c893706 ("blk: Call part_init() in the post_probe() method=
")
> >> removed the call to part_init() in mmc.c, as this is done by the DM_MMC
> >> framework.
> >> However Allwinner is (still) relying on a non-DM MMC driver, so we are
> >> now missing the implicit partition init, leading to failing MMC access=
es
> >> due to the missing partition information.
> >>
> >> Bring the call back just for non-DM MMC driver to fix this regression.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >> Tested-by: Soeren Moch <smoch@web.de>
> >> ---
> >>  drivers/mmc/mmc.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> >> index f5c821e308..d858127132 100644
> >> --- a/drivers/mmc/mmc.c
> >> +++ b/drivers/mmc/mmc.c
> >> @@ -2449,6 +2449,10 @@ static int mmc_startup(struct mmc *mmc)
> >>  	bdesc->revision[0] =3D 0;
> >>  #endif
> >> =20
> >> +#if !defined(CONFIG_DM_MMC) && (!defined(CONFIG_SPL_BUILD) || defined=
(CONFIG_SPL_LIBDISK_SUPPORT))
> >> +	part_init(bdesc);
> >> +#endif
> >> +
> >>  	return 0;
> >>  }
> >=20
> > So, this pushes pine_h64 over the limit:
> > https://travis-ci.org/trini/u-boot/jobs/477078336
>=20
> It seems you are missing patch 1/2?
> https://lists.denx.de/pipermail/u-boot/2018-December/352283.html
> (sunxi: drop default SPL_LIBDISK_SUPPORT enablement)
>=20
> I put this one in for exactly this reason.
>=20
> I have some other cleanups which reduce the H6 SPL size by 2K, will send
> them out shortly.

Thanks, I don't know why I thought that was in already.

--=20
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190109/6c858c62/a=
ttachment.sig>