From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFFFC43387 for ; Wed, 9 Jan 2019 16:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D937B20859 for ; Wed, 9 Jan 2019 16:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbfAIQuJ (ORCPT ); Wed, 9 Jan 2019 11:50:09 -0500 Received: from muru.com ([72.249.23.125]:32784 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbfAIQuI (ORCPT ); Wed, 9 Jan 2019 11:50:08 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5984F80C5; Wed, 9 Jan 2019 16:50:13 +0000 (UTC) Date: Wed, 9 Jan 2019 08:50:04 -0800 From: Tony Lindgren To: Vincent Guittot Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Ulf Hansson , "open list:THERMAL" , linux-kernel , LAK , Linux OMAP Mailing List , Ladislav Michl Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers Message-ID: <20190109165004.GQ5544@atomide.com> References: <20190107233833.GI5544@atomide.com> <20190108155354.GL5544@atomide.com> <20190108213743.GN5544@atomide.com> <20190109014218.GA8363@linaro.org> <20190109015124.GO5544@atomide.com> <20190109162846.GP5544@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Vincent Guittot [190109 16:48]: > On Wed, 9 Jan 2019 at 17:28, Tony Lindgren wrote: > > > > * Rafael J. Wysocki [190109 09:44]: > > > On Wed, Jan 9, 2019 at 2:51 AM Tony Lindgren wrote: > > > > > > > > * Vincent Guittot [190109 01:42]: > > > > > Le Tuesday 08 Jan 2019 à 13:37:43 (-0800), Tony Lindgren a écrit : > > > > > > Lowering the autosuspend_delay_ms to 2100 ms makes things work again. > > > > > > Anything higher than 2200 ms seems to somehow time out immediately > > > > > > now :) > > > > > > > > > > This is quite close to the max ns of an int on arm 32bits > > > > > > > > > > Could you try the patch below ? > > > > > > > > Yup great thanks, that's it: > > > > > > > > Tested-by: Tony Lindgren > > > > > > Cool. Thanks for getting to the bottom of this! > > > > No problem. > > > > One more thing I noticed: The 25% slack can get noticeable > > for larger values. For things like a 3 second uart console > > timeout slack of 750 ms is quite large variation. > > > > Should we have a limit of max 100 ms for the slack? > > Keep in mind that when jiffies were used, expires was rounded to a > full second when delay was greater than a second. So you could already > have difference of up 990ms on arm before this patch > And i don't take into account the rework of timer infra which add > another level of variation, something like up to 640 ms more when the > timer is greater than 2880 ms for arm IIRC I think it was rounded up earlier. Don't we get rounded down now also? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0E1C43387 for ; Wed, 9 Jan 2019 16:50:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 063E2206BB for ; Wed, 9 Jan 2019 16:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qa5+Q1Vj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 063E2206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j6UowEpnldoQ2Bw05zFN+MrPos5xHNvJ2ojL89d1fqc=; b=Qa5+Q1VjWocWq5 rJ1UEfyi91FmYDp7Yp9rgzD0BfZjEn3EgCvFvLFrCfwV3ykDCa3ZhjVHlFyvmVpot9bOPjQBaMS2P GR6dCkHUSJfvDxvsStB+Hp1rONH5f5KSjX6i0PtRNBwwFoSAfEgdH8TXlnpa5ymcHco6ZgaM6j1QI t5AKIjsKE4tNlJgTIikQMgoRWiZMNH862bFiqjdeIIpJN5y1WjzOcZYUNw9/UyLg6gqzDk2QG+ERi ZJdKPOs/fDI295NiyRzR8Fg9TGRJ13zJT6pXT6Nag4UgU+/7Db/XxjzKjHo8tReZRQzQU8jfvDqX0 e5uzLe9iyZc1KwoydhRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghH3T-0003Xz-5Z; Wed, 09 Jan 2019 16:50:11 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghH3Q-0003Ny-3u for linux-arm-kernel@lists.infradead.org; Wed, 09 Jan 2019 16:50:09 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5984F80C5; Wed, 9 Jan 2019 16:50:13 +0000 (UTC) Date: Wed, 9 Jan 2019 08:50:04 -0800 From: Tony Lindgren To: Vincent Guittot Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers Message-ID: <20190109165004.GQ5544@atomide.com> References: <20190107233833.GI5544@atomide.com> <20190108155354.GL5544@atomide.com> <20190108213743.GN5544@atomide.com> <20190109014218.GA8363@linaro.org> <20190109015124.GO5544@atomide.com> <20190109162846.GP5544@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_085008_205253_23B46511 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Ladislav Michl , "open list:THERMAL" , "Rafael J. Wysocki" , linux-kernel , "Rafael J. Wysocki" , Linux OMAP Mailing List , LAK Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBWaW5jZW50IEd1aXR0b3QgPHZpbmNlbnQuZ3VpdHRvdEBsaW5hcm8ub3JnPiBbMTkwMTA5IDE2 OjQ4XToKPiBPbiBXZWQsIDkgSmFuIDIwMTkgYXQgMTc6MjgsIFRvbnkgTGluZGdyZW4gPHRvbnlA YXRvbWlkZS5jb20+IHdyb3RlOgo+ID4KPiA+ICogUmFmYWVsIEouIFd5c29ja2kgPHJhZmFlbEBr ZXJuZWwub3JnPiBbMTkwMTA5IDA5OjQ0XToKPiA+ID4gT24gV2VkLCBKYW4gOSwgMjAxOSBhdCAy OjUxIEFNIFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+IHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4gKiBWaW5jZW50IEd1aXR0b3QgPHZpbmNlbnQuZ3VpdHRvdEBsaW5hcm8ub3JnPiBbMTkw MTA5IDAxOjQyXToKPiA+ID4gPiA+IExlIFR1ZXNkYXkgMDggSmFuIDIwMTkgw6AgMTM6Mzc6NDMg KC0wODAwKSwgVG9ueSBMaW5kZ3JlbiBhIMOpY3JpdCA6Cj4gPiA+ID4gPiA+IExvd2VyaW5nIHRo ZSBhdXRvc3VzcGVuZF9kZWxheV9tcyB0byAyMTAwIG1zIG1ha2VzIHRoaW5ncyB3b3JrIGFnYWlu Lgo+ID4gPiA+ID4gPiBBbnl0aGluZyBoaWdoZXIgdGhhbiAyMjAwIG1zIHNlZW1zIHRvIHNvbWVo b3cgdGltZSBvdXQgaW1tZWRpYXRlbHkKPiA+ID4gPiA+ID4gbm93IDopCj4gPiA+ID4gPgo+ID4g PiA+ID4gVGhpcyBpcyBxdWl0ZSBjbG9zZSB0byB0aGUgbWF4IG5zIG9mIGFuIGludCBvbiBhcm0g MzJiaXRzCj4gPiA+ID4gPgo+ID4gPiA+ID4gQ291bGQgeW91IHRyeSB0aGUgcGF0Y2ggYmVsb3cg Pwo+ID4gPiA+Cj4gPiA+ID4gWXVwIGdyZWF0IHRoYW5rcywgdGhhdCdzIGl0Ogo+ID4gPiA+Cj4g PiA+ID4gVGVzdGVkLWJ5OiBUb255IExpbmRncmVuIDx0b255QGF0b21pZGUuY29tPgo+ID4gPgo+ ID4gPiBDb29sLiAgVGhhbmtzIGZvciBnZXR0aW5nIHRvIHRoZSBib3R0b20gb2YgdGhpcyEKPiA+ Cj4gPiBObyBwcm9ibGVtLgo+ID4KPiA+IE9uZSBtb3JlIHRoaW5nIEkgbm90aWNlZDogVGhlIDI1 JSBzbGFjayBjYW4gZ2V0IG5vdGljZWFibGUKPiA+IGZvciBsYXJnZXIgdmFsdWVzLiBGb3IgdGhp bmdzIGxpa2UgYSAzIHNlY29uZCB1YXJ0IGNvbnNvbGUKPiA+IHRpbWVvdXQgc2xhY2sgb2YgNzUw IG1zIGlzIHF1aXRlIGxhcmdlIHZhcmlhdGlvbi4KPiA+Cj4gPiBTaG91bGQgd2UgaGF2ZSBhIGxp bWl0IG9mIG1heCAxMDAgbXMgZm9yIHRoZSBzbGFjaz8KPiAKPiBLZWVwIGluIG1pbmQgdGhhdCB3 aGVuIGppZmZpZXMgd2VyZSB1c2VkLCBleHBpcmVzIHdhcyByb3VuZGVkIHRvIGEKPiBmdWxsIHNl Y29uZCB3aGVuIGRlbGF5IHdhcyBncmVhdGVyIHRoYW4gYSBzZWNvbmQuIFNvIHlvdSBjb3VsZCBh bHJlYWR5Cj4gaGF2ZSBkaWZmZXJlbmNlIG9mIHVwIDk5MG1zIG9uIGFybSBiZWZvcmUgdGhpcyBw YXRjaAo+IEFuZCBpIGRvbid0IHRha2UgaW50byBhY2NvdW50IHRoZSByZXdvcmsgb2YgdGltZXIg aW5mcmEgd2hpY2ggYWRkCj4gYW5vdGhlciBsZXZlbCBvZiB2YXJpYXRpb24sIHNvbWV0aGluZyBs aWtlIHVwIHRvIDY0MCBtcyBtb3JlIHdoZW4gdGhlCj4gdGltZXIgaXMgZ3JlYXRlciB0aGFuIDI4 ODAgbXMgZm9yIGFybSBJSVJDCgpJIHRoaW5rIGl0IHdhcyByb3VuZGVkIHVwIGVhcmxpZXIuCgpE b24ndCB3ZSBnZXQgcm91bmRlZCBkb3duIG5vdyBhbHNvPwoKUmVnYXJkcywKClRvbnkKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK