All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	mingo@kernel.org, stern@rowland.harvard.edu,
	parri.andrea@gmail.com, will.deacon@arm.com,
	peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
	dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
	akiyks@gmail.com, willy@infradead.org
Subject: Re: [PATCH RFC memory-model 0/6] LKMM updates
Date: Thu, 10 Jan 2019 09:40:24 +0100	[thread overview]
Message-ID: <20190110084024.GA10280@andrea> (raw)
In-Reply-To: <20190110042027.GG1215@linux.ibm.com>

> > > > It seems that
> > > > 
> > > >   1b52d0186177 ("tools/memory-model: Model smp_mb__after_unlock_lock()")
> > > >   
> > > > from linux-rcu/dev got lost; this also needs an ack (probably yours! ;D,
> > > > considered that, IIRC, you introduced the primitive and RCU is currently
> > > > its only user.)
> > > 
> > > That commit is in -tip:
> > > 
> > > 4607abbcf464 ("tools/memory-model: Model smp_mb__after_unlock_lock()")
> > > 
> > > So it has already left my -rcu tree.  ;-)
> > 
> > Oh, you're right: now I see the commit (e.g., with "git show"), but I
> > don't see the corresponding changes applied to the tree.
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/core&id=4607abbcf464ea2be14da444215d05c73025cf6e
> >   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tree/tools/memory-model/linux-kernel.bell?h=locking/core
> > 
> > Is this expected?
> 
> Are you asking why it is in -tip but not in mainline?  I am not sure,
> but given that the merge window was over the holiday season and that
> the length of the merge window proved to be shorter than many people
> expected it to be, I am not too surprised.  ;-)

Mmh, let me try again:

  $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
  $ cd tip
  $ git checkout -b locking/core origin/locking/core

  $ git show 4607abbcf464
  commit 4607abbcf464ea2be14da444215d05c73025cf6e
  Author: Andrea Parri <andrea.parri@amarulasolutions.com>
  Date:   Mon Dec 3 15:04:49 2018 -0800

      tools/memory-model: Model smp_mb__after_unlock_lock()

  $ cd tools/memory-model
  $ herd7 -conf linux-kernel.cfg after-unlock-lock-same-cpu.litmus
  File "after-unlock-lock-same-cpu.litmus": Unknown macro smp_mb__after_unlock_lock (User error)

  [aka, linux-kernel.def in tip:locking/core does not have the
   smp_mb__after_unlock_lock() added by 4607abbcf464]

  Andrea


> 
> 							Thanx, Paul
> 

  reply	other threads:[~2019-01-10  8:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 21:07 [PATCH RFC memory-model 0/6] LKMM updates Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 1/7] tools/memory-model: Rename some RCU relations Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 2/7] tools/memory-model: Refactor " Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 3/7] tools/memory-model: Add SRCU support Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 4/7] tools/memory-model: Update README for addition of SRCU Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 5/7] docs/memory-barriers.txt: Enforce heavy ordering for port I/O accesses Paul E. McKenney
2019-01-11  9:53   ` Peter Zijlstra
2019-02-11 15:30   ` Will Deacon
2019-02-11 17:11     ` Arnd Bergmann
2019-02-11 17:32       ` Will Deacon
2019-01-09 21:07 ` [PATCH RFC LKMM 6/7] tools/memory-model: Update Documentation/explanation.txt to include SRCU support Paul E. McKenney
2019-01-09 21:07 ` [PATCH RFC LKMM 7/7] tools/memory-model: Dynamically check SRCU lock-to-unlock matching Paul E. McKenney
2019-01-10  9:41   ` Andrea Parri
2019-01-10 14:40     ` Paul E. McKenney
2019-01-10 23:20       ` Andrea Parri
2019-01-11 21:44         ` Paul E. McKenney
2019-01-11 21:57           ` Alan Stern
2019-01-11 21:57             ` Alan Stern
2019-01-09 23:18 ` [PATCH RFC memory-model 0/6] LKMM updates Andrea Parri
2019-01-09 23:40   ` Paul E. McKenney
2019-01-10  0:39     ` Andrea Parri
2019-01-10  4:20       ` Paul E. McKenney
2019-01-10  8:40         ` Andrea Parri [this message]
2019-01-10 14:31           ` Paul E. McKenney
2019-01-10 15:41             ` Alan Stern
2019-01-10 15:41               ` Alan Stern
2019-01-10 16:31               ` Paul E. McKenney
2019-01-10 22:46                 ` Andrea Parri
2019-01-10 15:47 ` Alan Stern
2019-01-10 15:47   ` Alan Stern
2019-01-10 19:03   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110084024.GA10280@andrea \
    --to=andrea.parri@amarulasolutions.com \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=mingo@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@linux.ibm.com \
    --cc=peterz@infradead.org \
    --cc=stern@rowland.harvard.edu \
    --cc=will.deacon@arm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.