From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: UBIFS quota support Date: Thu, 10 Jan 2019 12:44:48 +0100 Message-ID: <20190110114448.vcx6w76ibmxwvlh3@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Dongsheng Yang , Jan Kara , Richard Weinberger , Christoph Hellwig , linux-mtd@lists.infradead.org, kernel@pengutronix.de To: linux-fsdevel@vger.kernel.org Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-fsdevel.vger.kernel.org Hi all, I'm currently working on resurrecting the UBIFS quota patches posted back in 2015 by Dongsheng Yang, last posted here: http://lists.infradead.org/pipermail/linux-mtd/2015-September/061812.html First of all I think work stopped there, there is no newer UBIFS quota support I am missing, right? One problem with this series was that the quotactl systemcall expects a path to a block device. UBIFS doesn't work on a block device but on a character device instead. The solution in this series was to pass the path to the cdev in quotactl. A struct cdev * member was added to struct super_block which was used to identify the superblock for a given cdev. This approach was rejected by Christoph ("I don't think the cdev has any business in core VFS code."). Apart from that UBIFS can not only be mounted with a path to the character device (mount -t ubifs /dev/ubix_y /mnt) but also in the form ubix:volname (mount -t ubifs ubix:volname /mnt) in which case userspace doesn't have any valid path it could pass in quotactl. An idea out of this would be to allow to pass the mountpoint instead of the path to the block device in quotactl which would work with nfs or even tmpfs aswell. Would that be acceptable? Any other ideas? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97001C43387 for ; Thu, 10 Jan 2019 11:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E525214DA for ; Thu, 10 Jan 2019 11:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbfAJLov (ORCPT ); Thu, 10 Jan 2019 06:44:51 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:53513 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727938AbfAJLov (ORCPT ); Thu, 10 Jan 2019 06:44:51 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ghYlW-0005NX-1Q; Thu, 10 Jan 2019 12:44:50 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ghYlU-0006iA-Il; Thu, 10 Jan 2019 12:44:48 +0100 Date: Thu, 10 Jan 2019 12:44:48 +0100 From: Sascha Hauer To: linux-fsdevel@vger.kernel.org Cc: Dongsheng Yang , Jan Kara , linux-mtd@lists.infradead.org, Christoph Hellwig , Richard Weinberger , kernel@pengutronix.de Subject: UBIFS quota support Message-ID: <20190110114448.vcx6w76ibmxwvlh3@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:02:06 up 211 days, 20:11, 149 users, load average: 0.81, 0.39, 0.20 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-fsdevel@vger.kernel.org Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Message-ID: <20190110114448.oNRoB8ZebFcGJvxxH23Of31NEKdZI6hXrMdrO1ED3kQ@z> Hi all, I'm currently working on resurrecting the UBIFS quota patches posted back in 2015 by Dongsheng Yang, last posted here: http://lists.infradead.org/pipermail/linux-mtd/2015-September/061812.html First of all I think work stopped there, there is no newer UBIFS quota support I am missing, right? One problem with this series was that the quotactl systemcall expects a path to a block device. UBIFS doesn't work on a block device but on a character device instead. The solution in this series was to pass the path to the cdev in quotactl. A struct cdev * member was added to struct super_block which was used to identify the superblock for a given cdev. This approach was rejected by Christoph ("I don't think the cdev has any business in core VFS code."). Apart from that UBIFS can not only be mounted with a path to the character device (mount -t ubifs /dev/ubix_y /mnt) but also in the form ubix:volname (mount -t ubifs ubix:volname /mnt) in which case userspace doesn't have any valid path it could pass in quotactl. An idea out of this would be to allow to pass the mountpoint instead of the path to the block device in quotactl which would work with nfs or even tmpfs aswell. Would that be acceptable? Any other ideas? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |