All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] compat: merge compat library into EAL
Date: Thu, 10 Jan 2019 13:19:50 +0000	[thread overview]
Message-ID: <20190110131950.GA7312@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zkA5e8GqjyZdfBpMvaT8QHSOkj4e+hHUMCsAcPoOc4Ug@mail.gmail.com>

On Thu, Jan 10, 2019 at 01:53:20PM +0100, David Marchand wrote:
>    On Thu, Jan 10, 2019 at 1:28 PM David Marchand
>    <[1]david.marchand@redhat.com> wrote:
> 
>    On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson
>    <[2]bruce.richardson@intel.com> wrote:
> 
>      Since compat library is only a single header, we can easily move it
>      into
>      the EAL common headers instead of tracking it separately. The
>      downside of
>      this is that it becomes a little more difficult to have any libs
>      that are
>      built before EAL depend on it. Thankfully, this is not the case, so
>      there
>      are no big complications to the move.
>      However, to ensure that we don't later hit problems later with this,
>      we can
>      add EAL common headers folder to the global include list in the
>      meson build
>      which means that all common headers can be safely used by all
>      libraries, no
>      matter what their build order.
>      Signed-off-by: Bruce Richardson <[3]bruce.richardson@intel.com>
> 
>    Currently testing this patch, I just noticed some remaining traces of
>    librte_compat:
> 
>    Checked build with make and meson on rhel7.
>    --
>    David Marchand
>
Thanks, I'll check those out and do a V2.

/Bruce

  reply	other threads:[~2019-01-10 13:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 11:11 [PATCH] compat: merge compat library into EAL Bruce Richardson
2019-01-10 11:31 ` Burakov, Anatoly
2019-01-10 13:20   ` Bruce Richardson
2019-01-10 12:28 ` David Marchand
2019-01-10 12:53   ` David Marchand
2019-01-10 13:19     ` Bruce Richardson [this message]
2019-01-10 13:47 ` [PATCH v2] " Bruce Richardson
2019-01-10 13:57   ` David Marchand
2019-01-10 14:01     ` Bruce Richardson
2019-01-10 14:01   ` Burakov, Anatoly
2019-01-10 14:02   ` Burakov, Anatoly
2019-02-06 11:01 ` [PATCH v3] " Bruce Richardson
2019-02-06 12:22   ` Neil Horman
2019-02-06 14:17     ` Bruce Richardson
2019-02-07 14:34       ` Neil Horman
2019-02-07 15:03         ` Bruce Richardson
2019-02-08 15:37           ` Neil Horman
2019-02-08 16:18             ` Bruce Richardson
2019-02-08 16:55               ` Neil Horman
2019-02-08 17:13                 ` Bruce Richardson
2019-02-25 14:25                   ` Bruce Richardson
2019-02-25 14:59   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110131950.GA7312@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.