From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] compat: merge compat library into EAL Date: Thu, 10 Jan 2019 13:20:41 +0000 Message-ID: <20190110132041.GB7312@bricha3-MOBL.ger.corp.intel.com> References: <20190110111104.56464-1-bruce.richardson@intel.com> <6e9e1548-808d-cb86-a304-c8b8ac4491f4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, David Marchand , Thomas Monjalon To: "Burakov, Anatoly" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4E3A81B645 for ; Thu, 10 Jan 2019 14:20:45 +0100 (CET) Content-Disposition: inline In-Reply-To: <6e9e1548-808d-cb86-a304-c8b8ac4491f4@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 10, 2019 at 11:31:31AM +0000, Burakov, Anatoly wrote: > On 10-Jan-19 11:11 AM, Bruce Richardson wrote: > > Since compat library is only a single header, we can easily move it into > > the EAL common headers instead of tracking it separately. The downside of > > this is that it becomes a little more difficult to have any libs that are > > built before EAL depend on it. Thankfully, this is not the case, so there > > are no big complications to the move. > > > > However, to ensure that we don't later hit problems later with this, we can > > add EAL common headers folder to the global include list in the meson build > > which means that all common headers can be safely used by all libraries, no > > matter what their build order. > > > > Signed-off-by: Bruce Richardson > > --- > > Presumably this makes my patch obsolete? > If it also fixes the issue, yes. I suppose I'll need to pull in the fixes tag from your patch too, in that case. /Bruce