All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Acquire the AioContext during _realize()
Date: Fri, 11 Jan 2019 16:09:17 +0100	[thread overview]
Message-ID: <20190111150917.GL5010@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <cover.1547132561.git.berto@igalia.com>

Am 10.01.2019 um 16:03 hat Alberto Garcia geschrieben:
> As discussed yesterday, this series acquires the AioContext in the
> _realize() functions of several devices before making use of their
> block backends. This fixes at least a couple of crashes (in virtio-blk
> and scsi).

Apart from the incomplete scsi-block fix, this looks good. Of course,
I think patches 3-6 are completely optional because none of these
devices actually support iothreads, so we can't hit a bug. But it might
be nicer to add it there as well anyway.

For patches 1 and 2, which actually fix bugs, it would be nice to have
an accompanying test case.

Kevin

  parent reply	other threads:[~2019-01-11 15:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 15:03 [Qemu-devel] [PATCH 0/6] Acquire the AioContext during _realize() Alberto Garcia
2019-01-10 15:03 ` [Qemu-devel] [PATCH 1/6] block: Acquire the AioContext in virtio_blk_device_realize() Alberto Garcia
2019-01-10 15:03 ` [Qemu-devel] [PATCH 2/6] block: Acquire the AioContext in scsi_*_realize() Alberto Garcia
2019-01-11 15:02   ` Kevin Wolf
2019-01-11 15:05     ` Alberto Garcia
2019-01-11 15:14       ` Kevin Wolf
2019-01-10 15:03 ` [Qemu-devel] [PATCH 3/6] block: Acquire the AioContext in floppy_drive_realize() Alberto Garcia
2019-01-10 15:03 ` [Qemu-devel] [PATCH 4/6] block: Acquire the AioContext in nvme_realize() Alberto Garcia
2019-01-10 15:03 ` [Qemu-devel] [PATCH 5/6] block: Acquire the AioContext in ide_dev_initfn() Alberto Garcia
2019-01-10 15:03 ` [Qemu-devel] [PATCH 6/6] block: Acquire the AioContext in usb_msd_storage_realize() Alberto Garcia
2019-01-11 13:20 ` [Qemu-devel] [PATCH 0/6] Acquire the AioContext during _realize() Markus Armbruster
2019-01-11 15:09 ` Kevin Wolf [this message]
2019-01-11 15:13   ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111150917.GL5010@dhcp-200-186.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.