From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net] bridge: Fix ethernet header pointer before check skb forwardable Date: Sat, 12 Jan 2019 15:54:49 +0100 Message-ID: <20190112145449.GB16179@lunn.ch> References: <1547288907-18108-1-git-send-email-wangyunjian@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, xudingke@huawei.com To: wangyunjian Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:41111 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbfALOyw (ORCPT ); Sat, 12 Jan 2019 09:54:52 -0500 Content-Disposition: inline In-Reply-To: <1547288907-18108-1-git-send-email-wangyunjian@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Jan 12, 2019 at 06:28:27PM +0800, wangyunjian wrote: > From: Yunjian Wang > > The skb header should be set to ethernet header before using > is_skb_forwardable(including dev->hard_header_len length). Hi Yunjian I don't see any recent changes in this code. Do you know why this is needed now, yet it seemed to work before? Do you have a fixes: tag for where it broke? Thanks Andrew