From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9E6B81BF5EA for ; Mon, 14 Jan 2019 10:51:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9B5A121080 for ; Mon, 14 Jan 2019 10:51:41 +0000 (UTC) Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6SEK7qoUe3-Z for ; Mon, 14 Jan 2019 10:51:41 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by silver.osuosl.org (Postfix) with ESMTPS id 009D820796 for ; Mon, 14 Jan 2019 10:51:40 +0000 (UTC) Date: Mon, 14 Jan 2019 13:51:24 +0300 From: Dan Carpenter Subject: Re: rtl8192e: need help with variable naming convention Message-ID: <20190114105123.GA22496@kadam> References: <20190107105214.GA31559@kroah.com> <20190107130314.GD3200@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Himadri Pandya Cc: Greg KH , driverdev-devel@linuxdriverproject.org On Sat, Jan 12, 2019 at 10:31:08PM -0800, Himadri Pandya wrote: > On Mon, Jan 7, 2019 at 5:04 AM Dan Carpenter > wrote: > > > > > Ending a name with an underscore is quite ugly. > > > Yeah. That's right. So renaming it to channel_array[ ] instead. > Naming is hard. Having "_array" in the name isn't great either. It's normally obvious it's an array because of the [] characters. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel