From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.carpenter@oracle.com>
Date: Mon, 14 Jan 2019 15:37:27 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: rtl8192e: need help with variable naming convention
Message-ID: <20190114123727.GE4504@kadam>
References: <CAPnhUpZuYMAfor5jYeD-P4bP4aq=iMRN+fgXXSJc8qkRV_Yokw@mail.gmail.com>
 <20190107105214.GA31559@kroah.com>
 <20190107130314.GD3200@kadam>
 <CAPnhUpb7huehqHpLZ+Kz657xAZVCqLWYTW2RfK6Yy=mAP5QgYg@mail.gmail.com>
 <20190114105123.GA22496@kadam>
 <CAPnhUpacCUrqw3c_cA9A9mOTw7Lksd-Cy-XOZagxfqTQp9crfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPnhUpacCUrqw3c_cA9A9mOTw7Lksd-Cy-XOZagxfqTQp9crfQ@mail.gmail.com>
List-ID: <driverdev-devel.linuxdriverproject.org>
To: Himadri Pandya <himadri18.07@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, driverdev-devel@linuxdriverproject.org

On Mon, Jan 14, 2019 at 05:39:24PM +0530, Himadri Pandya wrote:
> On Mon, 14 Jan, 2019, 4:21 PM Dan Carpenter <dan.carpenter@oracle.com wrote:
> 
> Naming is hard.  Having "_array" in the name isn't great either.  It's
> > normally obvious it's an array because of the [] characters.
> >
> 
> Okay. How about renaming it to "_list[ ]" ? But I'm not sure if calling it
> a list will introduce redundancy or increase readability by showing we're
> implementing a list with an array?

_list is fine.  Or _array is fine, really.  Even channal_plan[] seems
Ok to me.  Something that mentions region, perhaps?  It's all fine.

So long as you're thinking about naming and trying to say something
then it's probably fine.  We're not trying to be ogres or to reject
patches.

regards,
dan carpenter