From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gj2Iq-0005aw-7d
	for mharc-grub-devel@gnu.org; Mon, 14 Jan 2019 08:29:20 -0500
Received: from eggs.gnu.org ([209.51.188.92]:39847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dkiper@net-space.pl>) id 1gj2Io-0005ZT-6Y
	for grub-devel@gnu.org; Mon, 14 Jan 2019 08:29:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dkiper@net-space.pl>) id 1gj2In-0000lF-Hd
	for grub-devel@gnu.org; Mon, 14 Jan 2019 08:29:18 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:33687)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24)
	(Exim 4.71) (envelope-from <dkiper@net-space.pl>) id 1gj2In-0000k8-7C
	for grub-devel@gnu.org; Mon, 14 Jan 2019 08:29:17 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:36348 "EHLO
	tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
	id S1001090AbfANN3O (ORCPT <rfc822;grub-devel@gnu.org>);
	Mon, 14 Jan 2019 14:29:14 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
	as: dkiper
Date: Mon, 14 Jan 2019 14:29:11 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Alexander Graf <agraf@suse.de>
Cc: grub-devel@gnu.org, Jon Masters <jcm@redhat.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 1/2] mkimage: Simplify header size logic
Message-ID: <20190114132911.mmk34h3ku3ghqyod@tomti.i.net-space.pl>
References: <20181223025207.40755-1-agraf@suse.de>
	<20181223025207.40755-2-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181223025207.40755-2-agraf@suse.de>
User-Agent: NeoMutt/20170113 (1.7.2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 84.10.22.86
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel/>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 13:29:18 -0000

On Sun, Dec 23, 2018 at 03:52:06AM +0100, Alexander Graf wrote:
> For EFI images, we always have the following layout:
>
>   [PE header]
>   [padding]
>   [first section (which also is the entry point)]
>
> Currently there are 2 places where we define how big header+padding are:
> in the .vaddr_offset member of our target image definition struct as well
> as in code in grub_install_generate_image().
>
> Remove the latter, so that we only have a single place to modify if we
> need to change the padding.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel