From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3.1 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots()
Date: Mon, 14 Jan 2019 18:21:07 +0100 [thread overview]
Message-ID: <20190114172107.GE2900@twin.jikos.cz> (raw)
In-Reply-To: <20190107054151.18662-4-wqu@suse.com>
On Mon, Jan 07, 2019 at 01:41:47PM +0800, Qu Wenruo wrote:
> +/*
> + * Helper structure to keep record of a file tree whose reloc
> + * root needs to be cleaned up.
> + *
> + * Since reloc_control is used less frequently than btrfs_root, this should
> + * prevent us to add another structure in btrfs_root.
> + */
> +struct dirty_source_root {
> + struct rb_node node;
> +
> + /* Root must be file tree */
The naming starts here and is used in the following patches too: the
naming is IMO confusing, here it's still ok but variables like
'file_bytenr' or 'file_parent' sound weird in context of relocation.
The file tree is the subvolume right, or would it be confusing in
another way?
next prev parent reply other threads:[~2019-01-14 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 5:41 [PATCH v3.1 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 1/7] btrfs: qgroup: Move reserved data account from btrfs_delayed_ref_head to btrfs_qgroup_extent_record Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 2/7] btrfs: qgroup: Don't trigger backref walk at delayed ref insert time Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots() Qu Wenruo
2019-01-14 17:04 ` David Sterba
2019-01-14 17:11 ` David Sterba
2019-01-15 0:44 ` Qu Wenruo
2019-01-14 17:21 ` David Sterba [this message]
2019-01-15 0:54 ` Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 4/7] btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 5/7] btrfs: qgroup: Introduce per-root swapped blocks infrastructure Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 6/7] btrfs: qgroup: Use delayed subtree rescan for balance Qu Wenruo
2019-01-07 5:41 ` [PATCH v3.1 7/7] btrfs: qgroup: Cleanup old subtree swap code Qu Wenruo
2019-01-08 14:27 ` [PATCH v3.1 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114172107.GE2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.