From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8199C43444 for ; Mon, 14 Jan 2019 18:50:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CF4B206B7 for ; Mon, 14 Jan 2019 18:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547491844; bh=R0RCV90C/gCsJedyEjs7rOopPTPZBSYIcIXJyVm1Yvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jIKepUoElpLz1Du6n/k0A39nzG3yXHbDZZyFJdaMqAtKUQ+jahTO6baECi6iWTCL1 2+9z76KkRJ7VWTwZHoeR033Xrn/NEkJHULc8QnLnatMFyjtWdyY9oNjr4G15qQ2cOU 9PcHgXlDx5QGTfCNReEAm0VaBjJphz/Abc0attek= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfANSuo (ORCPT ); Mon, 14 Jan 2019 13:50:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:33474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbfANSun (ORCPT ); Mon, 14 Jan 2019 13:50:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A091C2064C; Mon, 14 Jan 2019 18:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547491843; bh=R0RCV90C/gCsJedyEjs7rOopPTPZBSYIcIXJyVm1Yvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Plk36txM2OFIKuiB+rPBqVKe25l3DweRi34gKWV2CNy3RlVrz6fS3g4N+HoRIpgQn 5VXn/KGa/rLg2bObkFiQ4gdsUXb25YHA+20kcKKHnl+O1iNCeUauEgafmJyTkTVaKv S8n6lMZHqQvxZ3jjgBBcamF/50lXGdn80CUXJ6zk= Date: Mon, 14 Jan 2019 19:50:40 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Gwendal Grignou , "# v4 . 10+" , Guenter Roeck , Kees Cook Subject: Re: [PATCH v2] proc: Remove empty line in /proc/self/status Message-ID: <20190114185040.GB13821@kroah.com> References: <20190114181336.74501-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 14, 2019 at 10:21:45AM -0800, Guenter Roeck wrote: > On Mon, Jan 14, 2019 at 10:13 AM Gwendal Grignou wrote: > > > > Prevent an empty line in /proc/self/status, allow iotop to work. > > > > iotop does not like empty lines, fails with: > > File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line > > 196, in parse_proc_pid_status > > key, value = line.split(':\t', 1) > > ValueError: need more than 1 value to unpack > > > > [reading /proc/self/status] > > > > Fixes: 84964fa3e5a0 ("proc: Provide details on speculation flaw mitigations") > > > > Signed-off-by: Gwendal Grignou > > --- > > v2: Format commit message properly with proper subject and fixes > > keyword. > > > You might want to mention that this patch only applies to v4.4.y. > v4.9.y has a similar problem, but only if CONFIG_SECCOMP=n, and would > require a slightly different patch to fix. Other releases are, as far > as I can see, not affected. > > Guenter > > > fs/proc/array.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/proc/array.c b/fs/proc/array.c > > index 0c142916a8c7d..f11df9ab4256e 100644 > > --- a/fs/proc/array.c > > +++ b/fs/proc/array.c > > @@ -334,7 +334,7 @@ static inline void task_seccomp(struct seq_file *m, struct task_struct *p) > > #ifdef CONFIG_SECCOMP > > seq_printf(m, "Seccomp:\t%d\n", p->seccomp.mode); > > #endif > > - seq_printf(m, "\nSpeculation_Store_Bypass:\t"); > > + seq_printf(m, "Speculation_Store_Bypass:\t"); Why isn't this issue showing up in all kernel releases, as this line is still the same in 5.0-rc2? What makes the 4.4.y and 4.9.y trees so special here? confused, greg k-h