From: Mark Brown <broonie@kernel.org>
To: David Lechner <david@lechnology.com>
Cc: Vignesh R <vigneshr@ti.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] Revert "spi: omap2-mcspi: Set FIFO DMA trigger level to word length"
Date: Tue, 15 Jan 2019 00:07:51 +0000 [thread overview]
Message-ID: <20190115000751.GN11073@sirena.org.uk> (raw)
In-Reply-To: <bb7e13ee-f6ed-a619-c56e-53aad91a1432@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Mon, Jan 14, 2019 at 05:50:34PM -0600, David Lechner wrote:
> On 1/14/19 6:30 AM, Vignesh R wrote:
> > Oops, that's unfortunate. I see ili9225 is using bits_per_word = 16.
> > I believe commit b682cffa3ac6d9d broke spi_transfers where
> > bits_per_word anything other than 8 bits.
> > I don't have ili9225 HW but was able emulate this condition using a SPI
> > flash as slave on AM335x and successfully reproduced the issue. Could
> > you test if this diff[1] helps in fixing the regression without needing
> > to revert commit b682cffa3ac6d9d?
> Yes, this changes fixes the problem. Thanks!
Excellent! Vignesh, can you post a formal patch please and I'll get it
merged?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-15 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 20:49 [PATCH] Revert "spi: omap2-mcspi: Set FIFO DMA trigger level to word length" David Lechner
2019-01-13 20:52 ` David Lechner
2019-01-14 12:30 ` Vignesh R
2019-01-14 23:50 ` David Lechner
2019-01-15 0:07 ` Mark Brown [this message]
2019-01-14 23:57 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115000751.GN11073@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.