From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: Question about default m88e1510 LED configuration of marvell phy
Date: Tue, 15 Jan 2019 04:39:10 +0100
Message-ID: <20190115033910.GA11722@lunn.ch>
References: <1a4ecb58-7835-85f9-51b7-88b0cfca7eba@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>,
        Andrew Lunn <andrew@lun>, David Miller <davem@davemloft.net>,
        netdev@vger.kernel.org,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Dengweiwei <dengweiwei@huawei.com>
To: "shenjian (K)" <shenjian15@huawei.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:43260 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726769AbfAODjR (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 14 Jan 2019 22:39:17 -0500
Content-Disposition: inline
In-Reply-To: <1a4ecb58-7835-85f9-51b7-88b0cfca7eba@huawei.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote:
> Hi, all
> 	We encounted a problem when using the marvel 88e151x phy driver, the
> link(LED[0])/ack(LED[1]) leds worked abnormally since we updated our kernel to v4.19.
> The act led kept on and never blink.  It works well when we use genphy driver, aslo
> works well when use marvell phy in kernel v4.18.
> 
> 	I found that the default led configuration had been changed to 0x1177
> by commit commit 077772468ec1(net: phy: marvell: change default m88e1510 LED configuration).

It is a difficult job deciding what the driver should configure. I
would actually prefer to keeps with the reset default, which would be
0x101e according to the datasheet.

If you are using device tree, you have the option of poking values
into registers, using marvell,reg-init. There are a few examples you
can copy. Doing that guarantees you have the configuration you want.

    Andrew