All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: allwinner: a64: Fix a typo
@ 2019-01-13 16:14 ` Jonathan Neuschäfer
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2019-01-13 16:14 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Jonathan Neuschäfer, Maxime Ripard, Chen-Yu Tsai,
	Rob Herring, Mark Rutland, devicetree, linux-kernel

This typo inverted the meaning of the comment, but the rest of the
comment and the code reveal that the regulator in question needs to be
on at all times.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index c455b24dd079..f9eede0a8bd3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
@@ -239,7 +239,7 @@
 };
 
 /*
- * The A64 chip cannot work without this regulator off, although
+ * The A64 chip cannot work with this regulator off, although
  * it seems to be only driving the AR100 core.
  * Maybe we don't still know well about CPUs domain.
  */
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arm64: dts: allwinner: a64: Fix a typo
@ 2019-01-13 16:14 ` Jonathan Neuschäfer
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2019-01-13 16:14 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Mark Rutland, devicetree, Maxime Ripard,
	Jonathan Neuschäfer, linux-kernel, Chen-Yu Tsai,
	Rob Herring

This typo inverted the meaning of the comment, but the rest of the
comment and the code reveal that the regulator in question needs to be
on at all times.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index c455b24dd079..f9eede0a8bd3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
@@ -239,7 +239,7 @@
 };
 
 /*
- * The A64 chip cannot work without this regulator off, although
+ * The A64 chip cannot work with this regulator off, although
  * it seems to be only driving the AR100 core.
  * Maybe we don't still know well about CPUs domain.
  */
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: Fix a typo
  2019-01-13 16:14 ` Jonathan Neuschäfer
@ 2019-01-15  9:52   ` Maxime Ripard
  -1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-01-15  9:52 UTC (permalink / raw)
  To: Jonathan Neuschäfer
  Cc: linux-arm-kernel, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On Sun, Jan 13, 2019 at 05:14:13PM +0100, Jonathan Neuschäfer wrote:
> This typo inverted the meaning of the comment, but the rest of the
> comment and the code reveal that the regulator in question needs to be
> on at all times.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: Fix a typo
@ 2019-01-15  9:52   ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-01-15  9:52 UTC (permalink / raw)
  To: Jonathan Neuschäfer
  Cc: Mark Rutland, devicetree, linux-kernel, Chen-Yu Tsai,
	Rob Herring, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

On Sun, Jan 13, 2019 at 05:14:13PM +0100, Jonathan Neuschäfer wrote:
> This typo inverted the meaning of the comment, but the rest of the
> comment and the code reveal that the regulator in question needs to be
> on at all times.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-15 15:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 16:14 [PATCH] arm64: dts: allwinner: a64: Fix a typo Jonathan Neuschäfer
2019-01-13 16:14 ` Jonathan Neuschäfer
2019-01-15  9:52 ` Maxime Ripard
2019-01-15  9:52   ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.