All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
	linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP
Date: Tue, 15 Jan 2019 16:13:17 +0100	[thread overview]
Message-ID: <20190115151317.GA17860@kroah.com> (raw)
In-Reply-To: <b547970693963d6e62845c7925a75ef68122f1ba.1547476997.git.nishadkamdar@gmail.com>

On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
> 
> Reviewed-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>

Did you test build this patch?

It fails horribly for me:

drivers/staging/greybus/gpio.c: In function ‘gb_gpio_request_handler’:
drivers/staging/greybus/gpio.c:389:34: error: ‘struct gpio_chip’ has no member named ‘irq’
  irq = irq_find_mapping(ggc->chip.irq.domain, event->which);
                                  ^
  CC [M]  drivers/staging/rtl8712/usb_intf.o
drivers/staging/greybus/gpio.c: In function ‘gb_gpio_probe’:
drivers/staging/greybus/gpio.c:577:8: error: implicit declaration of function ‘gpiochip_irqchip_add’; did you mean ‘gpiochip_add’? [-Werror=implicit-function-declaration]
  ret = gpiochip_irqchip_add(gpio, irqc, 0, handle_level_irq,
        ^~~~~~~~~~~~~~~~~~~~
        gpiochip_add


Please be more careful...

greg k-h

  reply	other threads:[~2019-01-15 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 14:55 [PATCH v7 0/3] greybus: gpio: Switch to the gpio descriptor interface Nishad Kamdar
2019-01-14 14:56 ` [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP Nishad Kamdar
2019-01-15 15:13   ` Greg Kroah-Hartman [this message]
2019-01-15 15:15     ` Greg Kroah-Hartman
2019-01-14 14:57 ` [PATCH v7 2/3] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface Nishad Kamdar
2019-01-14 14:58 ` [PATCH v7 3/3] staging: greybus: arche-platform: " Nishad Kamdar
2019-01-14 15:04 ` [PATCH v7 0/3] greybus: gpio: " Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115151317.GA17860@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.