From: Daniel Vetter <daniel@ffwll.ch>
To: James Clarke <jrtc27@jrtc27.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix drm.h uapi header for GNU/kFreeBSD
Date: Tue, 15 Jan 2019 16:17:23 +0100 [thread overview]
Message-ID: <20190115151723.GQ10517@phenom.ffwll.local> (raw)
In-Reply-To: <20190115150418.68080-1-jrtc27@jrtc27.com>
On Tue, Jan 15, 2019 at 03:04:18PM +0000, James Clarke wrote:
> Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t
> types, which differs from the BSDs' headers. Thus we should include
> stdint.h to ensure we have all the required integer types.
>
> Signed-off-by: James Clarke <jrtc27@jrtc27.com>
Would be good to get an ack from some other *bsd that this is still all
fine. lgtm otherwise.
-Daniel
> ---
> include/uapi/drm/drm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> index 300f33663..caf4d9b38 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -50,6 +50,7 @@ typedef unsigned int drm_handle_t;
>
> #else /* One of the BSDs */
>
> +#include <stdint.h>
> #include <sys/ioccom.h>
> #include <sys/types.h>
> typedef int8_t __s8;
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-15 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:04 [PATCH] drm: Fix drm.h uapi header for GNU/kFreeBSD James Clarke
2019-01-15 15:17 ` Daniel Vetter [this message]
2019-01-15 18:41 ` Eric Anholt
2019-05-04 20:43 ` James Clarke
2019-05-06 8:16 ` Daniel Vetter
2019-05-06 23:10 ` James Clarke
2019-05-07 8:26 ` Daniel Vetter
2019-05-09 17:42 ` Eric Anholt
2019-05-16 16:37 ` Eric Anholt
2019-05-16 16:58 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115151723.GQ10517@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrtc27@jrtc27.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.