From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AC9C43444 for ; Tue, 15 Jan 2019 18:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4076520859 for ; Tue, 15 Jan 2019 18:01:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="E8Xth/Xm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387575AbfAOSB6 (ORCPT ); Tue, 15 Jan 2019 13:01:58 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44098 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731121AbfAOSB6 (ORCPT ); Tue, 15 Jan 2019 13:01:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y6qymBUnaGBdxoHfJPOHNkpd6rnKVj1CJGMBMub1phg=; b=E8Xth/XmpVt+HW4BTk1jfi9sU hBpevwf9A5cbub2hwslhZK2FVL1JAzNaUYSvhreDPq+/USkHL7gyysB3R1rr7d283g0sm1+G+kBS+ 4gKV3Y+Z5Q0q5MMqXEKafp+ed/UhyeIqYJ9KMj71g1ILkW6//PK+O14q3xdI7ECnAdPhgBQq0HMs7 SsiFxDfwo+lmtDQqSsWIhNQ5430EkJbUSTX5YVUN57oqHjdZkNUsHeFaRJ9zn58KAYlBSCILZFAyj kjUM8lHPAHYCQzXJeuqdwkFeW5D3QuND3eCfnRbu6+GtLOOObX3H2tZXEzrMNyL9SAz2hv94Rx/ZS Hkw4+yvDw==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjT2C-0006nt-UM; Tue, 15 Jan 2019 18:01:56 +0000 Date: Tue, 15 Jan 2019 10:01:56 -0800 From: Matthew Wilcox To: Linus Torvalds Cc: Jan Kara , linux-fsdevel , linux-ext4@vger.kernel.org, Al Viro Subject: Re: [GIT PULL] dtype handling cleanup for v4.21-rc1 Message-ID: <20190115180156.GB6310@bombadil.infradead.org> References: <20190102174736.GB29127@quack2.suse.cz> <20190108100500.GA15801@quack2.suse.cz> <20190115092414.GA4138@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 16, 2019 at 05:36:06AM +1200, Linus Torvalds wrote: > On Tue, Jan 15, 2019 at 9:24 PM Jan Kara wrote: > > > > What has happened to this pull request? It may be too late for this to be > > merged now but I'd like to understand why it was not merged or rejected... > > Sorry, initially I left if for later consideration after rc1, and then > I just forgot about it. > > I didn't see much point to the cleanup when it actually adds lots of > lines and no actual advantage. The whole dentry type translation > really is fs-specific and it might just happen to be shared. But why > share it if it only adds complexity and unnecessary abstraction? The ext2/ext4 patches don't show much improvement. The other patches show more: fs/nilfs2/dir.c | 52 ++++++++++-------------------- include/uapi/linux/nilfs2_ondisk.h | 1 + 2 files changed, 18 insertions(+), 35 deletions(-) (for example). UFS ends up benefiting the most. You can see the whole diffstat here: https://lore.kernel.org/lkml/20181023201952.GA15676@pathfinder/ We'd see a lot more improvement in line count if Philip weren't quite so paranoid about checking FOOFS_FT_* == FT_* at build time; eg for btrfs: https://lore.kernel.org/lkml/20181023211728.GA16584@pathfinder/