From: Florian Westphal <fw@strlen.de>
To: wenxu@ucloud.cn
Cc: pablo@netfilter.org, fw@strlen.de, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type
Date: Tue, 15 Jan 2019 19:03:00 +0100 [thread overview]
Message-ID: <20190115180300.plsfkbxqxj5cxsau@breakpoint.cc> (raw)
In-Reply-To: <1547565584-16842-1-git-send-email-wenxu@ucloud.cn>
wenxu@ucloud.cn <wenxu@ucloud.cn> wrote:
> nft add rule firewall rules-all meta iifkind vrf counter accept
Looks good to me.
Only comment (unrelated to this patch):
could you make nft parser enforce quoted string (meta iifkind "vrf")?
Thanks!
prev parent reply other threads:[~2019-01-15 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:19 [PATCH v2] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type wenxu
2019-01-15 18:03 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115180300.plsfkbxqxj5cxsau@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.