From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/4] sideband: reverse its dependency on pkt-line
Date: Wed, 16 Jan 2019 11:34:38 +0100 [thread overview]
Message-ID: <20190116103438.GG840@szeder.dev> (raw)
In-Reply-To: <5aa5d047c828a0db10544c706dd595f09db3215d.1547581039.git.jonathantanmy@google.com>
On Tue, Jan 15, 2019 at 11:40:28AM -0800, Jonathan Tan wrote:
> A subsequent patch will teach struct packet_reader a new field that, if
> set, instructs it to interpret read data as multiplexed. This will
> create a dependency from pkt-line to sideband.
>
> To avoid a circular dependency, split recv_sideband() into 2 parts: the
> reading loop (left in recv_sideband()) and the processing of the
> contents (in demultiplex_sideband()), and move the former into pkt-line.
> This reverses the direction of dependency: sideband no longer depends on
> pkt-line, and pkt-line now depends on sideband.
In the last couple of days I noticed occasional but frequent failures
in the test 'leading space' in 't5409-colorize-remote-messas.sh' on
'pu' and on this topic. Bisect suggests that this patch is the
culprit, but of course bisecting an occasional test failure can't be
completely trusted.
The trace output of the failing test looks like this:
+ git --git-dir child/.git -c color.remote=always push -f origin HEAD:refs/heads/leading-space
+ cat output
remote: error: error
remote: ERROR: also highlighted
remote: hint: hint
remote: hinting: not highlighted
remote: success: success
remote: warning: warning
remote: prefixerror: error
remote:
remote: error: leading space
remote:
remote: Err
To /<...>/trash directory.t5409-colorize-remote-messages.stress-4/.
* [new branch] HEAD -> leading-space
+ test_decode_color
+ awk
< ... snip enormous awk script ... >
+ grep <BOLD;RED>error<RESET>: leading space decoded
error: last command exited with $?=1
not ok 6 - leading space
Notice how that "error: leading space" lines up with the other
messages. On 'master' that line looks like this:
remote: error: leading space
next prev parent reply other threads:[~2019-01-16 10:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 22:18 [PATCH 0/4] Sideband the whole fetch v2 response Jonathan Tan
2019-01-11 22:18 ` [PATCH 1/4] pkt-line: introduce struct packet_writer Jonathan Tan
2019-01-14 20:07 ` Junio C Hamano
2019-01-15 18:18 ` Jonathan Tan
2019-01-11 22:18 ` [PATCH 2/4] sideband: reverse its dependency on pkt-line Jonathan Tan
2019-01-14 20:07 ` Junio C Hamano
2019-01-14 22:11 ` Junio C Hamano
2019-01-15 18:38 ` Jonathan Tan
2019-01-15 18:36 ` Jonathan Tan
2019-01-11 22:18 ` [PATCH 3/4] {fetch,upload}-pack: sideband v2 fetch response Jonathan Tan
2019-01-14 22:27 ` Junio C Hamano
2019-01-15 19:18 ` Jonathan Tan
2019-01-11 22:18 ` [PATCH 4/4] tests: define GIT_TEST_SIDEBAND_ALL Jonathan Tan
2019-01-11 22:18 ` [WIP 5/4] Documentation: order protocol v2 sections Jonathan Tan
2019-01-11 22:18 ` [WIP 6/4] Documentation: add Packfile URIs design doc Jonathan Tan
2019-01-11 22:18 ` [WIP 7/4] upload-pack: refactor reading of pack-objects out Jonathan Tan
2019-01-11 22:18 ` [WIP 8/4] upload-pack: send part of packfile response as uri Jonathan Tan
2019-01-15 19:40 ` [PATCH v2 0/4] Sideband the whole fetch v2 response Jonathan Tan
2019-01-15 19:40 ` [PATCH v2 1/4] pkt-line: introduce struct packet_writer Jonathan Tan
2019-01-15 19:40 ` [PATCH v2 2/4] sideband: reverse its dependency on pkt-line Jonathan Tan
2019-01-16 10:34 ` SZEDER Gábor [this message]
2019-01-16 17:43 ` Jonathan Tan
2019-01-16 19:17 ` SZEDER Gábor
2019-01-15 19:40 ` [PATCH v2 3/4] {fetch,upload}-pack: sideband v2 fetch response Jonathan Tan
2019-01-15 19:40 ` [PATCH v2 4/4] tests: define GIT_TEST_SIDEBAND_ALL Jonathan Tan
2019-01-15 19:50 ` [PATCH v2 0/4] Sideband the whole fetch v2 response Junio C Hamano
2019-01-15 21:11 ` Junio C Hamano
2019-01-15 22:08 ` Jonathan Tan
2019-01-15 22:35 ` Junio C Hamano
2019-01-15 23:02 ` Jonathan Tan
2019-01-15 23:13 ` Junio C Hamano
2019-01-16 0:38 ` Jonathan Tan
2019-01-16 4:12 ` Junio C Hamano
2019-01-16 19:28 ` [PATCH v3 " Jonathan Tan
2019-01-16 19:28 ` [PATCH v3 1/4] pkt-line: introduce struct packet_writer Jonathan Tan
2019-01-16 19:28 ` [PATCH v3 2/4] sideband: reverse its dependency on pkt-line Jonathan Tan
2019-01-16 19:28 ` [PATCH v3 3/4] {fetch,upload}-pack: sideband v2 fetch response Jonathan Tan
2019-01-16 19:28 ` [PATCH v3 4/4] tests: define GIT_TEST_SIDEBAND_ALL Jonathan Tan
2019-01-29 23:27 ` Jonathan Nieder
2019-02-13 6:49 ` Jeff King
2019-01-17 19:43 ` [PATCH v3 0/4] Sideband the whole fetch v2 response Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116103438.GG840@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.