All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Cole Robinson" <crobinso@redhat.com>,
	libvirt-list@redhat.com, qemu-devel@nongnu.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional
Date: Wed, 16 Jan 2019 21:24:11 -0200	[thread overview]
Message-ID: <20190116232411.GE14807@habkost.net> (raw)
In-Reply-To: <a85c6b3f384fc82c7d5d2debf8c7ad0eedcbb657.camel@redhat.com>

On Wed, Jan 16, 2019 at 05:24:02PM +0100, Andrea Bolognani wrote:
> On Wed, 2019-01-16 at 15:40 +0000, Daniel P. Berrangé wrote:
> > On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote:
> > > But I don't want to create unnecessary obstacles for libvirt, so
> > > if there's a real benefit in promising compatibility between both
> > > device types, we can still promise that on the QEMU side.
> > 
> > I don't think there's an obstacle for libvirt, as I don't see any
> > compelling reason to avoid the new devices when we have QEMU >= 4.0.
> 
> Alright, let's do it that way then.
> 
> I still think it's important to maintain the relationship between
> old and new devices consistent going forward, because not doing so
> will certainly result in confusion for those using QEMU directly.

Agreed that it's a good thing to have.  I will extend the
existing virtio_version.py test case to be more strict and try to
catch mistakes that would break compatibility between the two
device types in the future.

-- 
Eduardo

      reply	other threads:[~2019-01-16 23:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1547420060.git.crobinso@redhat.com>
     [not found] ` <1ac81ba920b03d153f80236fea5aa81321e054fa.1547420060.git.crobinso@redhat.com>
     [not found]   ` <20190115165614.GL16157@redhat.com>
     [not found]     ` <624086124c9a2673c627203f3310fd63495e00c0.camel@redhat.com>
     [not found]       ` <20190116113953.GO20275@redhat.com>
     [not found]         ` <d3fd5d3bf9a6823b24756b4f376e20903ac1a575.camel@redhat.com>
     [not found]           ` <20190116124445.GS20275@redhat.com>
     [not found]             ` <2b4954e50ad51e7b3bdaf6b7b183254e2a1cd70d.camel@redhat.com>
     [not found]               ` <20190116143722.GY20275@redhat.com>
2019-01-16 14:45                 ` [Qemu-devel] [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional Eduardo Habkost
2019-01-16 15:40                   ` Daniel P. Berrangé
2019-01-16 16:24                     ` Andrea Bolognani
2019-01-16 23:24                       ` Eduardo Habkost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116232411.GE14807@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=abologna@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=libvirt-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.