From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC17C43387 for ; Thu, 17 Jan 2019 09:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 074DE20851 for ; Thu, 17 Jan 2019 09:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbfAQJf6 (ORCPT ); Thu, 17 Jan 2019 04:35:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:54256 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726914AbfAQJf5 (ORCPT ); Thu, 17 Jan 2019 04:35:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 333C0AA71; Thu, 17 Jan 2019 09:35:56 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 2C3381E1580; Thu, 17 Jan 2019 10:35:55 +0100 (CET) Date: Thu, 17 Jan 2019 10:35:55 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , Phillip Potter , Linus Torvalds , "cc: Matthew Wilcox" , linux-fsdevel , Ext4 , Al Viro Subject: Re: [GIT PULL] dtype handling cleanup for v4.21-rc1 Message-ID: <20190117093555.GC9378@quack2.suse.cz> References: <20190102174736.GB29127@quack2.suse.cz> <20190108100500.GA15801@quack2.suse.cz> <20190115092414.GA4138@quack2.suse.cz> <20190115180156.GB6310@bombadil.infradead.org> <20190116120754.GF26069@quack2.suse.cz> <20190116165147.GI26069@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 16-01-19 18:56:17, Amir Goldstein wrote: > On Wed, Jan 16, 2019 at 6:51 PM Jan Kara wrote: > > > > On Wed 16-01-19 16:34:36, Phillip Potter wrote: > > > Dear Jan, > > > > > > I am happy to rework the patches, all fair comment. Slight problem > > > being my computer is in a box right now as I've just moved house. I > > > will get this done in the next few days if that's ok? > > > > Sure, no problem. Patches won't make it in this release cycle so we have > > like three weeks to get them ready for the next merge window. > > > > Also, and Jan will correct me if I am wrong. > I think that reworking only the common and ext2 patches would > be sufficient for this cycle. Yes, that's also true. > You can prepare the rest of the patches for next cycle after > the common patch has landed. Correct, since the plan is for these to land through other maintainers' trees. But still it would be nice if we had them earlier just to see of other maintainers don't seriously oppose the idea. To that end it is probably good to reference the discussion with Linus in the cover letter and the email with common infrastructure, explaining why converting to common defines instead of keeping filesystem specific ones was done. Honza -- Jan Kara SUSE Labs, CR