From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA076C43387 for ; Thu, 17 Jan 2019 14:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A90FF20851 for ; Thu, 17 Jan 2019 14:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727986AbfAQOzi (ORCPT ); Thu, 17 Jan 2019 09:55:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59670 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbfAQOzh (ORCPT ); Thu, 17 Jan 2019 09:55:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41AE53C20E; Thu, 17 Jan 2019 14:55:37 +0000 (UTC) Received: from redhat.com (ovpn-122-124.rdu2.redhat.com [10.10.122.124]) by smtp.corp.redhat.com (Postfix) with SMTP id 2D47F4D9F7; Thu, 17 Jan 2019 14:55:35 +0000 (UTC) Date: Thu, 17 Jan 2019 09:55:35 -0500 From: "Michael S. Tsirkin" To: Toshiaki Makita Cc: "David S. Miller" , Jason Wang , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Willem de Bruijn , Jesper Dangaard Brouer Subject: Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx Message-ID: <20190117095243-mutt-send-email-mst@kernel.org> References: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 17 Jan 2019 14:55:37 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote: > While I'm looking into how to account standard tx counters on XDP tx > processing, I found several bugs around XDP tx and napi_tx. > > Patch1: Fix oops on error path. Patch2 depends on this. > Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled. > Patch3: Minor fix patch5 depends on. > Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled. > Also patch5 depends on this. > Patch5: Fix memory corruption on processing xdp_frames while XDP is being > disabled. > Patch6: Minor fix patch7 depends on. > Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal > queue is reused for XDP and vise versa. > > Signed-off-by: Toshiaki Makita Series: Acked-by: Michael S. Tsirkin I guess we need this stuff on stable? I'm especially happy with Patch7 as it makes my BQL work a bit easier. > Toshiaki Makita (7): > virtio_net: Don't enable NAPI when interface is down > virtio_net: Don't call free_old_xmit_skbs for xdp_frames > virtio_net: Fix not restoring real_num_rx_queues > virtio_net: Fix out of bounds access of sq > virtio_net: Don't process redirected XDP frames when XDP is disabled > virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs > virtio_net: Differentiate sk_buff and xdp_frame on freeing > > drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 109 insertions(+), 45 deletions(-) > > -- > 1.8.3.1 >