From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Thu, 17 Jan 2019 17:45:41 +0100 Message-ID: <20190117164541.GE3271@phenom.ffwll.local> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190116181018.GA27364-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sam Ravnborg Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Oleksandr Andrushchenko , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, CK Hu , spice-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jani Nikula , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jani Nikula , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rodrigo Vivi List-Id: linux-tegra@vger.kernel.org T24gV2VkLCBKYW4gMTYsIDIwMTkgYXQgMDc6MTA6MThQTSArMDEwMCwgU2FtIFJhdm5ib3JnIHdy b3RlOgo+IEhpIERhbmllbC4KPiAKPiA+IHY1OiBBY3R1YWxseSB0cnkgdG8gc29ydCB0aGVtLCBh bmQgd2hpbGUgYXQgaXQsIHNvcnQgYWxsIHRoZSBvbmVzIEkKPiA+IHRvdWNoLgo+IAo+IEFwcGxp ZWQgdGhpcyB2YXJpYW50IG9uIHRvcCBvZiBkcm0tbWlzYyBhbmQgZGlkIGEgYnVpbGQgdGVzdC4K PiBMb29rZWQgZ29vZCBmb3IgaWE2NCwgeDg2IGFuZCBhbHBoYS4KPiAKPiBUb29rIGEgY2xvc2Vy IGxvb2sgYXQgdGhlIGNoYW5nZXMgdG8gYXRtZWxfaGxjZCAtIGFuZCB0aGV5IGxvb2tlZCBPSy4K PiAKPiBCdXQgSSBub3RpY2VkIHRoYXQgYXRtZWxfaGxjZGMgdXNlcyBvbmx5IGRybV9rbXNfaGVs cGVyX3BvbGxfaW5pdCgpIGFuZAo+IGRybV9rbXNfaGVscGVyX3BvbGxfZmluaSgpLgo+IEJ1dCB0 aGVyZSBhcmUgbm8gaGl0cyBvbiBEUk1fQ09OTkVDVE9SX1BPTEwgLSBzbyBJIHRoaW5rIHdlIG1h eWJlCj4gaGF2ZSBhIGRyaXZlciBoZXJlIHdoZXJlIHdlIGhhdmUgcGx1Z2dlZCB0aGUgZHJtX3Bv bGwgaW5mcmFzdHJ1Y3R1cmUsCj4gYnV0IGl0IGlzIG5vdCBpbiB1c2UuCj4gCj4gPiAgaW5jbHVk ZS9kcm0vZHJtX2NydGNfaGVscGVyLmggICAgICAgICAgICAgICAgIHwgMTYgLS0tLS0tLS0tLS0K PiAKPiBUaGUgbGlzdCBvZiBpbmNsdWRlIGZpbGVzIGluIHRoaXMgZmlsZSBjb3VsZCBiZSBkcm9w cGVkIGFuZCByZXBsYWNlZCBieToKPiBzdHJ1Y3QgZHJtX2Nvbm5lY3RvcjsKPiBzdHJ1Y3QgZHJt X2RldmljZTsKPiBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZTsKPiBzdHJ1Y3QgZHJtX2VuY29kZXI7 Cj4gc3RydWN0IGRybV9mcmFtZWJ1ZmZlcjsKPiBzdHJ1Y3QgZHJtX21vZGVfc2V0Owo+IHN0cnVj dCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eDsKPiAKPiBJIHRyaWVkIHRvIGRvIHNvIG9uIHRvcCBv ZiB5b3VyIHBhdGNoLgo+IEJ1dCB0aGVyZSB3ZXJlIHRvbyBtYW55IGJ1aWxkIGVycnJvcyBhbmQg SSBzb21laG93IGxvc3QgdGhlIG1vdGl2YXRpb24uCgpZZWFoIHRoZSBkcm1fY3J0Y19oZWxwZXIu aCBoZWFkZXIgaXMgYSBiaXQgdGhlIG1pbmlhdHVyZSBkcm1QLmggZm9yIGxlZ2FjeQprbXMgZHJp dmVycy4gSnVzdCByZW1vdmluZyBpdCBmcm9tIGFsbCB0aGUgYXRvbWljIGRyaXZlcnMgY2F1c2Vk IGxvdHMgb2YKZmFsbG91dCwgSSBleHBlY3QgZXZlbiBtb3JlIGlmIHlvdSBlbnRpcmVseSByZW1v dmUgdGhlIGluY2x1ZGVzIGl0IGhhcy4KTWF5YmUgYSB0b2RvLCBjYXJlIHRvIHBscyBjcmVhdGUg dGhhdCBwYXRjaCBzaW5jZSBpdCdzIHlvdXIgaWRlYT8KLURhbmllbAoKPiAKPiAKPiA+ICBpbmNs dWRlL2RybS9kcm1fcHJvYmVfaGVscGVyLmggICAgICAgICAgICAgICAgfCAyNyArKysrKysrKysr KysrKysrKysrCj4gVGhpcyBvbiB0aGUgb3RoZXIgaGFuZCBpcyBmaW5lIC0gYXMgZXhwZWN0ZWQg YXMgdGhpcyBpcyBhIG5ldyBmaWxlLgo+IAo+IEJ1dCB0aGUgYWJvdmUgaXMganVzdCBzb21lIHJh bmRvbSBjb21tZW50cyBzbzoKPiAKPiBBY2tlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJv cmcub3JnPgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ZyZWVkcmVubwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C333C43387 for ; Thu, 17 Jan 2019 16:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDE1C20859 for ; Thu, 17 Jan 2019 16:45:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XpIqV969" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbfAQQpr (ORCPT ); Thu, 17 Jan 2019 11:45:47 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:42496 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728848AbfAQQpr (ORCPT ); Thu, 17 Jan 2019 11:45:47 -0500 Received: by mail-ed1-f68.google.com with SMTP id y20so8852455edw.9 for ; Thu, 17 Jan 2019 08:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=XpIqV969SvphAZ4y55B9XsKLgH5TOJSk0+trqqG8gDbFtpm4Avk64xaCR7WNFFsl5S JMleF9lJImURSKKsp62Ic+TwgHzTXVrtXdZPwnZwJH3YhEsrURl89JNSvJGmelZGHx2G 5Z521lKbdU6z8w08x0T017vudJpBi/+iK7KBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=LZ1fuZP24W0Uk7dmLvrPvY2/Tt4/FJfFIlMe9w3mVYJw7fTid1OxC/5ps9MJkNmjfO fe4/u1FRubdB3v4rRYAIePrDcF74l3DkGv3gJI8xknMrIswmhyEg490Q52+SomrH4h77 o5PqN5my/SaVJL2lTj8yhJYqi1QQYsUeZhgq+4476GF+CA4KPluhWJIowGyMeHVwYDbj reZjIR9/ZqXeg2Sk3i+snBKj2vKp31ZvHU6duEEGGLVntjNHBLZl90CrlmwlRG8fiM0v hkDpE2ENPUka+Ie6BSU/A7Uky/zfPKe+J7vxCGZjHZ1OztW9EFoqxUbslf0B/0QGwwsp jSmw== X-Gm-Message-State: AJcUukfxavZ+srY2KXdl1WyWYjYOOWLKybBiFd4sE5CnFDivO0QXJgsl 2Dpah09LveWW03LMpuFA1WrziQ== X-Google-Smtp-Source: ALg8bN48Ho/mM8Q7a3cuSaUxZAOeetJgITKLeb5lpfoqSNcRkQ2JHWoWIcrUFnFvvuK4Y1nyvIf4ig== X-Received: by 2002:a17:906:3105:: with SMTP id 5-v6mr11397796ejx.122.1547743544951; Thu, 17 Jan 2019 08:45:44 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id g37sm6730501edb.85.2019.01.17.08.45.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 08:45:44 -0800 (PST) Date: Thu, 17 Jan 2019 17:45:41 +0100 From: Daniel Vetter To: Sam Ravnborg Cc: Daniel Vetter , DRI Development , Jani Nikula , Laurent Pinchart , Rodrigo Vivi , Benjamin Gaignard , Jani Nikula , Neil Armstrong , Oleksandr Andrushchenko , CK Hu , Alex Deucher , Liviu Dudau , Daniel Vetter , linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, xen-devel@lists.xen.org Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117164541.GE3271@phenom.ffwll.local> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116181018.GA27364@ravnborg.org> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > v5: Actually try to sort them, and while at it, sort all the ones I > > touch. > > Applied this variant on top of drm-misc and did a build test. > Looked good for ia64, x86 and alpha. > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini(). > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > have a driver here where we have plugged the drm_poll infrastructure, > but it is not in use. > > > include/drm/drm_crtc_helper.h | 16 ----------- > > The list of include files in this file could be dropped and replaced by: > struct drm_connector; > struct drm_device; > struct drm_display_mode; > struct drm_encoder; > struct drm_framebuffer; > struct drm_mode_set; > struct drm_modeset_acquire_ctx; > > I tried to do so on top of your patch. > But there were too many build errros and I somehow lost the motivation. Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy kms drivers. Just removing it from all the atomic drivers caused lots of fallout, I expect even more if you entirely remove the includes it has. Maybe a todo, care to pls create that patch since it's your idea? -Daniel > > > > include/drm/drm_probe_helper.h | 27 +++++++++++++++++++ > This on the other hand is fine - as expected as this is a new file. > > But the above is just some random comments so: > > Acked-by: Sam Ravnborg -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6746FC43387 for ; Thu, 17 Jan 2019 16:45:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25C0720856 for ; Thu, 17 Jan 2019 16:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K+DdahGT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XpIqV969" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25C0720856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nwqb1ya0pDx5CRwSBM/FlbmHCIvOOtPrXNO8ZcIZoTQ=; b=K+DdahGTzrFpb/ FyaQjsYEQWQbXr6hxiMAeUIokRbkSgbFFipf6yQzAfSptJH8TA5F8jaO5Wxv77Fr1rg1Ri2jfMEI4 aGGKFQJW1++++XchHo6o6b0pa8DwpvZlH3/0htfDbJTKLNgUmJteEi1fZXVQTBnWKoU6HLcupfYiK RITXZElhu4p8tlCGpO00PBPiVmOpn+DOQbz2KuRj23CEY5Grym7tt2KkDgMayH4jmN4DiD1S8h9Wx I6bLyN+9jN1DLyfamIY49Nmx61mquPraMZq0hk3WF5pjrV8O4NNIupdSQs2iA9rTvd14cvWwt6B+P m34PWttpXcJssSETYNJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAni-000879-R2; Thu, 17 Jan 2019 16:45:54 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAnb-00083n-IZ for linux-arm-kernel@lists.infradead.org; Thu, 17 Jan 2019 16:45:50 +0000 Received: by mail-ed1-x541.google.com with SMTP id f9so8856191eds.10 for ; Thu, 17 Jan 2019 08:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=XpIqV969SvphAZ4y55B9XsKLgH5TOJSk0+trqqG8gDbFtpm4Avk64xaCR7WNFFsl5S JMleF9lJImURSKKsp62Ic+TwgHzTXVrtXdZPwnZwJH3YhEsrURl89JNSvJGmelZGHx2G 5Z521lKbdU6z8w08x0T017vudJpBi/+iK7KBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=csqu2ALk9Z/uWQhtQHh432X3i7zItiPItyER1WyvM6gjyXwMglSszwhytSHBJL4zER ueZKP+tLco62ghTzMrqyHU6JVcnCjwGAnZ7GSP+/JZP61RRedOC+wfMQkO//ni1EJtCe h/wD35b3qe1SBK7Cf59qak3Ar8LFXiEf+nsNbs5Y0wAHQG41qVWLqV1t8L+jI1CHpq/G 1QCLJjyUkCZVtMbqyZeXxOVo1yQ++7w3DBaApgEYZVJ3mmDlteDerc1C4edzJnB4sUc2 me8vz0yDBWVSPglLkgWet9UhnCTdVS2RsRm4yqi03071M/F9189pmxrqk9byqGEs7HsX whaw== X-Gm-Message-State: AJcUukcfzVdPahksXwUZsXFgaLEx1zJONvLN7u59e0zsa+LPxVAEQFgq DH/yW2C+xpTK0avE5+kkNsIpIw== X-Google-Smtp-Source: ALg8bN48Ho/mM8Q7a3cuSaUxZAOeetJgITKLeb5lpfoqSNcRkQ2JHWoWIcrUFnFvvuK4Y1nyvIf4ig== X-Received: by 2002:a17:906:3105:: with SMTP id 5-v6mr11397796ejx.122.1547743544951; Thu, 17 Jan 2019 08:45:44 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id g37sm6730501edb.85.2019.01.17.08.45.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 08:45:44 -0800 (PST) Date: Thu, 17 Jan 2019 17:45:41 +0100 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117164541.GE3271@phenom.ffwll.local> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190116181018.GA27364@ravnborg.org> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_084547_694701_CDAE0D44 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, CK Hu , spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > v5: Actually try to sort them, and while at it, sort all the ones I > > touch. > > Applied this variant on top of drm-misc and did a build test. > Looked good for ia64, x86 and alpha. > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini(). > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > have a driver here where we have plugged the drm_poll infrastructure, > but it is not in use. > > > include/drm/drm_crtc_helper.h | 16 ----------- > > The list of include files in this file could be dropped and replaced by: > struct drm_connector; > struct drm_device; > struct drm_display_mode; > struct drm_encoder; > struct drm_framebuffer; > struct drm_mode_set; > struct drm_modeset_acquire_ctx; > > I tried to do so on top of your patch. > But there were too many build errros and I somehow lost the motivation. Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy kms drivers. Just removing it from all the atomic drivers caused lots of fallout, I expect even more if you entirely remove the includes it has. Maybe a todo, care to pls create that patch since it's your idea? -Daniel > > > > include/drm/drm_probe_helper.h | 27 +++++++++++++++++++ > This on the other hand is fine - as expected as this is a new file. > > But the above is just some random comments so: > > Acked-by: Sam Ravnborg -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EF0C43387 for ; Thu, 17 Jan 2019 16:46:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3758620856 for ; Thu, 17 Jan 2019 16:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pgKqryUY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XpIqV969" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3758620856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LghBaTQXvVex70qQcwpb2WhTILes8VVE8U2vBJFpXhY=; b=pgKqryUY+8vPMT a++jkgtlm3vpKex/8QyllS4yQjJCCJ4VdSNdtbZIrnwFK7iaJXaXqaikE6gHk32ed93aYYjy7KpU1 L2mT8E9FcAUrL6SdfIyp+l9AmNtQV0dlWmcROpI7qiUR3MOpeWkOO2sosP2FcE5VeivfNge+UesT9 QXr9jyIa77fznJhhxiQyk5ItNJq7YNQXc+uHmTfQmtjyVDkVyp8lzWDw5T18EtAET3Tfrsuf2NvcA FmPmAI6cQwD6KcC4FcTVbCQS6D9Es4UZGxdRTudYj+xBumsIN9B9DHqV7nrYZ95fpdevZPw7bJolc Nq+hpvw7gFNqbEVXQvqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAng-00085W-30; Thu, 17 Jan 2019 16:45:52 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAnb-00083l-IF for linux-amlogic@lists.infradead.org; Thu, 17 Jan 2019 16:45:49 +0000 Received: by mail-ed1-x544.google.com with SMTP id d39so8833368edb.12 for ; Thu, 17 Jan 2019 08:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=XpIqV969SvphAZ4y55B9XsKLgH5TOJSk0+trqqG8gDbFtpm4Avk64xaCR7WNFFsl5S JMleF9lJImURSKKsp62Ic+TwgHzTXVrtXdZPwnZwJH3YhEsrURl89JNSvJGmelZGHx2G 5Z521lKbdU6z8w08x0T017vudJpBi/+iK7KBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=m3DrXDcPhvu47BbFUx4zQy571KlJYDDGKK5BJgX8TXUxOV/V31QUDweoXj7Md+K8C/ FaRctpTmmPrA5Nb879MexxkqS7DH7mHq1rCwbJY5sSVDXa4lflP2jBTvP2Qyq+jRgXk0 kEo4+ByZtuDAbBFeHcxxdahVxOsYIXXKbN9XBYRunulpfT5sAfoGchS4+ZfRmdxwviwO tQSioXafgRxecLNtU/T/io8Ofo1IyF61CMGzlrB9kiG5ndnbPGplci4V2Rp+EZ+v8U/5 4nBwjNhlCo6X3gE7XfcAUsEBHyg3uFt3kwOMTY06ueLPbNKFHEnKR5Jv78h3CkD9zZ2p +cug== X-Gm-Message-State: AJcUukciAu8Fxo3d6GrQMR0dmu+kwxPrDWjKsBZojNGysLDu+e0o9pU1 UygTkAnorMmoPmOa1sTH+yr7Fg== X-Google-Smtp-Source: ALg8bN48Ho/mM8Q7a3cuSaUxZAOeetJgITKLeb5lpfoqSNcRkQ2JHWoWIcrUFnFvvuK4Y1nyvIf4ig== X-Received: by 2002:a17:906:3105:: with SMTP id 5-v6mr11397796ejx.122.1547743544951; Thu, 17 Jan 2019 08:45:44 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id g37sm6730501edb.85.2019.01.17.08.45.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 08:45:44 -0800 (PST) Date: Thu, 17 Jan 2019 17:45:41 +0100 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117164541.GE3271@phenom.ffwll.local> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190116181018.GA27364@ravnborg.org> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_084547_687543_AD713328 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, CK Hu , spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > v5: Actually try to sort them, and while at it, sort all the ones I > > touch. > > Applied this variant on top of drm-misc and did a build test. > Looked good for ia64, x86 and alpha. > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini(). > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > have a driver here where we have plugged the drm_poll infrastructure, > but it is not in use. > > > include/drm/drm_crtc_helper.h | 16 ----------- > > The list of include files in this file could be dropped and replaced by: > struct drm_connector; > struct drm_device; > struct drm_display_mode; > struct drm_encoder; > struct drm_framebuffer; > struct drm_mode_set; > struct drm_modeset_acquire_ctx; > > I tried to do so on top of your patch. > But there were too many build errros and I somehow lost the motivation. Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy kms drivers. Just removing it from all the atomic drivers caused lots of fallout, I expect even more if you entirely remove the includes it has. Maybe a todo, care to pls create that patch since it's your idea? -Daniel > > > > include/drm/drm_probe_helper.h | 27 +++++++++++++++++++ > This on the other hand is fine - as expected as this is a new file. > > But the above is just some random comments so: > > Acked-by: Sam Ravnborg -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic