From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Thu, 17 Jan 2019 18:45:31 +0100 Message-ID: <20190117174531.GA14041@ravnborg.org> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> <20190117164541.GE3271@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190117164541.GE3271@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.or List-Id: linux-tegra@vger.kernel.org T24gVGh1LCBKYW4gMTcsIDIwMTkgYXQgMDU6NDU6NDFQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIEphbiAxNiwgMjAxOSBhdCAwNzoxMDoxOFBNICswMTAwLCBTYW0gUmF2 bmJvcmcgd3JvdGU6Cj4gPiBIaSBEYW5pZWwuCj4gPiAKPiA+ID4gdjU6IEFjdHVhbGx5IHRyeSB0 byBzb3J0IHRoZW0sIGFuZCB3aGlsZSBhdCBpdCwgc29ydCBhbGwgdGhlIG9uZXMgSQo+ID4gPiB0 b3VjaC4KPiA+IAo+ID4gQXBwbGllZCB0aGlzIHZhcmlhbnQgb24gdG9wIG9mIGRybS1taXNjIGFu ZCBkaWQgYSBidWlsZCB0ZXN0Lgo+ID4gTG9va2VkIGdvb2QgZm9yIGlhNjQsIHg4NiBhbmQgYWxw aGEuCj4gPiAKPiA+IFRvb2sgYSBjbG9zZXIgbG9vayBhdCB0aGUgY2hhbmdlcyB0byBhdG1lbF9o bGNkIC0gYW5kIHRoZXkgbG9va2VkIE9LLgo+ID4gCj4gPiBCdXQgSSBub3RpY2VkIHRoYXQgYXRt ZWxfaGxjZGMgdXNlcyBvbmx5IGRybV9rbXNfaGVscGVyX3BvbGxfaW5pdCgpIGFuZAo+ID4gZHJt X2ttc19oZWxwZXJfcG9sbF9maW5pKCkuCj4gPiBCdXQgdGhlcmUgYXJlIG5vIGhpdHMgb24gRFJN X0NPTk5FQ1RPUl9QT0xMIC0gc28gSSB0aGluayB3ZSBtYXliZQo+ID4gaGF2ZSBhIGRyaXZlciBo ZXJlIHdoZXJlIHdlIGhhdmUgcGx1Z2dlZCB0aGUgZHJtX3BvbGwgaW5mcmFzdHJ1Y3R1cmUsCj4g PiBidXQgaXQgaXMgbm90IGluIHVzZS4KPiA+IAo+ID4gPiAgaW5jbHVkZS9kcm0vZHJtX2NydGNf aGVscGVyLmggICAgICAgICAgICAgICAgIHwgMTYgLS0tLS0tLS0tLS0KPiA+IAo+ID4gVGhlIGxp c3Qgb2YgaW5jbHVkZSBmaWxlcyBpbiB0aGlzIGZpbGUgY291bGQgYmUgZHJvcHBlZCBhbmQgcmVw bGFjZWQgYnk6Cj4gPiBzdHJ1Y3QgZHJtX2Nvbm5lY3RvcjsKPiA+IHN0cnVjdCBkcm1fZGV2aWNl Owo+ID4gc3RydWN0IGRybV9kaXNwbGF5X21vZGU7Cj4gPiBzdHJ1Y3QgZHJtX2VuY29kZXI7Cj4g PiBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyOwo+ID4gc3RydWN0IGRybV9tb2RlX3NldDsKPiA+IHN0 cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eDsKPiA+IAo+ID4gSSB0cmllZCB0byBkbyBzbyBv biB0b3Agb2YgeW91ciBwYXRjaC4KPiA+IEJ1dCB0aGVyZSB3ZXJlIHRvbyBtYW55IGJ1aWxkIGVy cnJvcyBhbmQgSSBzb21laG93IGxvc3QgdGhlIG1vdGl2YXRpb24uCj4gCj4gWWVhaCB0aGUgZHJt X2NydGNfaGVscGVyLmggaGVhZGVyIGlzIGEgYml0IHRoZSBtaW5pYXR1cmUgZHJtUC5oIGZvciBs ZWdhY3kKPiBrbXMgZHJpdmVycy4gSnVzdCByZW1vdmluZyBpdCBmcm9tIGFsbCB0aGUgYXRvbWlj IGRyaXZlcnMgY2F1c2VkIGxvdHMgb2YKPiBmYWxsb3V0LCBJIGV4cGVjdCBldmVuIG1vcmUgaWYg eW91IGVudGlyZWx5IHJlbW92ZSB0aGUgaW5jbHVkZXMgaXQgaGFzLgo+IE1heWJlIGEgdG9kbywg Y2FyZSB0byBwbHMgY3JlYXRlIHRoYXQgcGF0Y2ggc2luY2UgaXQncyB5b3VyIGlkZWE/CgpUaGUg bWFpbiByZWFzb24gSSBiYWlsZWQgb3V0IGluaXRpYWxseSB3YXMgdGhhdCB0aGlzIHdvdWxkIGNy ZWF0ZQpzbWFsbCBjaGFuZ2VzIHRvIHNldmVyYWwgb3RoZXJ3aXNlIHNlbGRvbWx5IHRvdWNoZWQg ZmlsZXMuCkFuZCB0aGVuIHdlIHdvdWxkIGxhdGVyIGNvbWUgYW5kIHJlbW92ZSBkcm1QLmggLSBz byBsb3RzIG9mCnNtYWxsIGJ1dCBpbmNyZW1lbnRhbCBjaGFuZ2VzIHRvIHRoZSBzYW1lIG90aGVy d2lzZSBzZWxkb21seQplZGl0ZWQgZmlsZXMuCkFuZCB0aGUgam9iIHdhcyBvbmx5IHBhcnRpYWxs eSBkb25lLgoKSSB3aWxsIHRyeSB0byBleHBlcmltZW50IHdpdGggYW4gYXBwcm9hY2ggd2hlcmUg SSBjbGVhbiB1cCB0aGUKaW5jbHVkZS9kcm0vKi5oIGZpbGVzIGEgbGl0dGxlIChsaWtlIHN1Z2dl c3RlZCBhYm92ZSwgK2RlbGV0ZSBkcm1QLmgKYW5kIG1heWJlIGEgYml0IG1vcmUpLgoKVGhlbiB0 byB0cnkgb24gYSBkcml2ZXIgYnkgZHJpdmVyIGJhc2lzIHRvIG1ha2UgaXQgYnVpbGQgd2l0aCBh CmNsZWFuZWQgc2V0IG9mIGluY2x1ZGUgZmlsZXMuCkkgaG9wZSB0aGF0IHRoZSBjbGVhbmVkIHVw IGRyaXZlciBjYW4gc3RpbGwgYnVpbGQgd2l0aG91dCB0aGUKY2xlYW5lZCBoZWFkZXIgZmlsZXMg c28gdGhlIGNoYW5nZXMgY2FuIGJlIHN1Ym1pdHRlZCBwaWVjZW1hbC4KCldpbGwgZG8gc28gd2l0 aCBhbiBleWUgb24gdGhlIGxlc3NlciBtYWludGFpbmVkIGRyaXZlcnMgdG8gdHJ5IGl0Cm91dCB0 byBhdm9pZCBjcmVhdGluZyB0b28gbXVjaCBjaHJ1bmNoIGZvciBvdGhlcnMuCgpBbmQgaWYgaXQg d29ya3Mgb3V0IEkgZXhwZWN0IHRoZSBhY3RpdmUgZHJpdmVycyB0byBmb2xsb3cgdGhlCmV4YW1w bGUuCgp0b2RvLnJzdCBpdGVtIHdpbGwgd2FpdCB1bnRpbCBJIHJ1biBvdXQgb2YgZW5lcmd5LgoK CVNhbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AA1C43444 for ; Thu, 17 Jan 2019 17:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA46720868 for ; Thu, 17 Jan 2019 17:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfAQRzg (ORCPT ); Thu, 17 Jan 2019 12:55:36 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:45840 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726517AbfAQRzf (ORCPT ); Thu, 17 Jan 2019 12:55:35 -0500 X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Jan 2019 12:55:33 EST Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id C974F8036E; Thu, 17 Jan 2019 18:45:32 +0100 (CET) Date: Thu, 17 Jan 2019 18:45:31 +0100 From: Sam Ravnborg To: Daniel Vetter Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117174531.GA14041@ravnborg.org> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> <20190117164541.GE3271@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190117164541.GE3271@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=xwHcfvD0iotqNkNuR-sA:9 a=CjuIK1q_8ugA:10 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Jan 17, 2019 at 05:45:41PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > > v5: Actually try to sort them, and while at it, sort all the ones I > > > touch. > > > > Applied this variant on top of drm-misc and did a build test. > > Looked good for ia64, x86 and alpha. > > > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > > drm_kms_helper_poll_fini(). > > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > > have a driver here where we have plugged the drm_poll infrastructure, > > but it is not in use. > > > > > include/drm/drm_crtc_helper.h | 16 ----------- > > > > The list of include files in this file could be dropped and replaced by: > > struct drm_connector; > > struct drm_device; > > struct drm_display_mode; > > struct drm_encoder; > > struct drm_framebuffer; > > struct drm_mode_set; > > struct drm_modeset_acquire_ctx; > > > > I tried to do so on top of your patch. > > But there were too many build errros and I somehow lost the motivation. > > Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy > kms drivers. Just removing it from all the atomic drivers caused lots of > fallout, I expect even more if you entirely remove the includes it has. > Maybe a todo, care to pls create that patch since it's your idea? The main reason I bailed out initially was that this would create small changes to several otherwise seldomly touched files. And then we would later come and remove drmP.h - so lots of small but incremental changes to the same otherwise seldomly edited files. And the job was only partially done. I will try to experiment with an approach where I clean up the include/drm/*.h files a little (like suggested above, +delete drmP.h and maybe a bit more). Then to try on a driver by driver basis to make it build with a cleaned set of include files. I hope that the cleaned up driver can still build without the cleaned header files so the changes can be submitted piecemal. Will do so with an eye on the lesser maintained drivers to try it out to avoid creating too much chrunch for others. And if it works out I expect the active drivers to follow the example. todo.rst item will wait until I run out of energy. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2909C43387 for ; Thu, 17 Jan 2019 17:45:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7186F20652 for ; Thu, 17 Jan 2019 17:45:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Thv72cD7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7186F20652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NJh5u59BeluftaCvIaNVFLKfdSIzPLUzWzQGJvksgwg=; b=Thv72cD74PRRxE a1G012mR3SRGyGwSWvD6GVmqMzjw9J9JvGQjujPMbU/j0Qjko29Y5lrBKddj8lS91NA+Zc0BM8imX avWxtMnl97f+CyUSTxLMcsSstRQ+KX/ENNelpGSqDlc7k3cY0FWaMf0/RKi4RuyuDyhC1ZOquOexH d2IWIGrhkIFHsoIDBOfOvfUxtLTNgNeFlJIMENUWn00I2UnswTwr9VOFXkn9CDBxbuOufwLNDWjN0 5acq/jKKgU35tIEQiT1krEiLRHr//B7o/sz040JpXd2xas5UWZ7O6Eee8JVyWhfDKVyw55CWsToIT 4LVpXnVJeamEjRhWzrsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkBja-0006le-C1; Thu, 17 Jan 2019 17:45:42 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkBjV-0006kd-A0; Thu, 17 Jan 2019 17:45:39 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id C974F8036E; Thu, 17 Jan 2019 18:45:32 +0100 (CET) Date: Thu, 17 Jan 2019 18:45:31 +0100 From: Sam Ravnborg To: Daniel Vetter Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117174531.GA14041@ravnborg.org> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> <20190117164541.GE3271@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190117164541.GE3271@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=xwHcfvD0iotqNkNuR-sA:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_094537_700247_5ACEF66E X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 17, 2019 at 05:45:41PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > > v5: Actually try to sort them, and while at it, sort all the ones I > > > touch. > > > > Applied this variant on top of drm-misc and did a build test. > > Looked good for ia64, x86 and alpha. > > > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > > drm_kms_helper_poll_fini(). > > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > > have a driver here where we have plugged the drm_poll infrastructure, > > but it is not in use. > > > > > include/drm/drm_crtc_helper.h | 16 ----------- > > > > The list of include files in this file could be dropped and replaced by: > > struct drm_connector; > > struct drm_device; > > struct drm_display_mode; > > struct drm_encoder; > > struct drm_framebuffer; > > struct drm_mode_set; > > struct drm_modeset_acquire_ctx; > > > > I tried to do so on top of your patch. > > But there were too many build errros and I somehow lost the motivation. > > Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy > kms drivers. Just removing it from all the atomic drivers caused lots of > fallout, I expect even more if you entirely remove the includes it has. > Maybe a todo, care to pls create that patch since it's your idea? The main reason I bailed out initially was that this would create small changes to several otherwise seldomly touched files. And then we would later come and remove drmP.h - so lots of small but incremental changes to the same otherwise seldomly edited files. And the job was only partially done. I will try to experiment with an approach where I clean up the include/drm/*.h files a little (like suggested above, +delete drmP.h and maybe a bit more). Then to try on a driver by driver basis to make it build with a cleaned set of include files. I hope that the cleaned up driver can still build without the cleaned header files so the changes can be submitted piecemal. Will do so with an eye on the lesser maintained drivers to try it out to avoid creating too much chrunch for others. And if it works out I expect the active drivers to follow the example. todo.rst item will wait until I run out of energy. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346FAC43444 for ; Thu, 17 Jan 2019 17:45:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0334320868 for ; Thu, 17 Jan 2019 17:45:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RuskIGVA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0334320868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mMv9y/jDz6shJz85GmJ1RFI17UVVQ4usGyRHiZFg/UI=; b=RuskIGVAUCQlpK K+CBWnBgSYR0FqtxY6Vc0gbSxi3aQc32xgvXOb1BmGo3Y/7rMfPCI18Hqz16xzDmlmsxzNQeu7Mb4 sdRa9ez/pKmXnOOGDQNns+cgrRFDy30JwE2zO01Av+ntLyzJgo3n0H6cz6IBIyuuR6RVcquEG8zkF +Kwozws7okGPqWFcSAq6/uSUgqy8q746yYMZeC9TdYde6FFBX3XrdDoeWq/vfAuWU3/zw1mEtlfjw mAfw4J+oEHBWFZ7rFgrCtEfh38IwEUqL7nYCfTA4SqmtCONDaaeRuHKyfFqWy1uYjtlTexrgDkZWp dXeW7o2aAYRlRE+ZgtuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkBjY-0006l8-PN; Thu, 17 Jan 2019 17:45:40 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkBjV-0006kd-A0; Thu, 17 Jan 2019 17:45:39 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id C974F8036E; Thu, 17 Jan 2019 18:45:32 +0100 (CET) Date: Thu, 17 Jan 2019 18:45:31 +0100 From: Sam Ravnborg To: Daniel Vetter Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117174531.GA14041@ravnborg.org> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> <20190117164541.GE3271@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190117164541.GE3271@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=xwHcfvD0iotqNkNuR-sA:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_094537_700247_5ACEF66E X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Jan 17, 2019 at 05:45:41PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > > v5: Actually try to sort them, and while at it, sort all the ones I > > > touch. > > > > Applied this variant on top of drm-misc and did a build test. > > Looked good for ia64, x86 and alpha. > > > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > > drm_kms_helper_poll_fini(). > > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > > have a driver here where we have plugged the drm_poll infrastructure, > > but it is not in use. > > > > > include/drm/drm_crtc_helper.h | 16 ----------- > > > > The list of include files in this file could be dropped and replaced by: > > struct drm_connector; > > struct drm_device; > > struct drm_display_mode; > > struct drm_encoder; > > struct drm_framebuffer; > > struct drm_mode_set; > > struct drm_modeset_acquire_ctx; > > > > I tried to do so on top of your patch. > > But there were too many build errros and I somehow lost the motivation. > > Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy > kms drivers. Just removing it from all the atomic drivers caused lots of > fallout, I expect even more if you entirely remove the includes it has. > Maybe a todo, care to pls create that patch since it's your idea? The main reason I bailed out initially was that this would create small changes to several otherwise seldomly touched files. And then we would later come and remove drmP.h - so lots of small but incremental changes to the same otherwise seldomly edited files. And the job was only partially done. I will try to experiment with an approach where I clean up the include/drm/*.h files a little (like suggested above, +delete drmP.h and maybe a bit more). Then to try on a driver by driver basis to make it build with a cleaned set of include files. I hope that the cleaned up driver can still build without the cleaned header files so the changes can be submitted piecemal. Will do so with an eye on the lesser maintained drivers to try it out to avoid creating too much chrunch for others. And if it works out I expect the active drivers to follow the example. todo.rst item will wait until I run out of energy. Sam _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic