From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 11/13] drm/i915: Turn off pipe gamma when it's not needed. Date: Thu, 17 Jan 2019 10:40:23 -0800 Message-ID: <20190117184023.GL4563@mdroper-desk.amr.corp.intel.com> References: <20190111170823.4441-1-ville.syrjala@linux.intel.com> <20190111170823.4441-12-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DD716E40B for ; Thu, 17 Jan 2019 18:40:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190111170823.4441-12-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMTEsIDIwMTkgYXQgMDc6MDg6MjFQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFRoZSBwaXBlIGludGVybmFsIHByZWNpc2lvbiBpcyBoaWdoZXIgdGhhbiB3aGF0 IHdlIGN1cnJlbnRseSBwcm9ncmFtIHRvCj4gdGhlIGRlZ2FtbWEvZ2FtbWEgTFVUcy4gV2UgY2Fu IGdldCBhIGhpZ2hlciBxdWFsaXR5IGltYWdlIGJ5IGJ5cGFzc2luZwo+IHRoZSBMVVRzIHdoZW4g dGhleSdyZSBub3QgbmVlZGVkLiBMZXQncyBkbyB0aGF0Lgo+IAo+IEVhY2ggcGxhbmUgaGFzIGl0 cyBvd24gY29udHJvbCBiaXQgZm9yIHRoaXMsIHNvIHdlIGhhdmUgdG8gdXBkYXRlCj4gYWxsIGFj dGl2ZSBwbGFuZXMuIFRoZSB3YXkgd2UndmUgZG9uZSB0aGlzIHdlIGRvbid0IGFjdHVhbGx5IGhh dmUKPiB0byBydW4gdGhyb3VnaCB0aGUgd2hvbGUgLmNoZWNrX3BsYW5lKCkgdGhpbmcuIEFuZCB3 ZSBhY3R1YWxseQo+IGRvIHRoZSAuY29sb3JfY2hlY2soKSBhZnRlciAuY2hlY2tfcGxhbmUoKSBz byB3ZSBjb3VsZG4ndCBldmVuIGRvCj4gdGhhdCB3aXRob3V0IHNodWZmbGluZyB0aGUgY29kZSBh cm91bmQuCj4gCj4gQWRkaXRpb25hbGx5IG9uIHByZS1za2wgd2UgaGF2ZSB0byB1cGRhdGUgdGhl IHByaW1hcnkgcGxhbmUgcmVnYXJkbGVzcwo+IG9mIHdoZXRoZXIgaXQncyBhY3RpdmUgb3Igbm90 IG9uIGFjY291bnQgb2YgdGhlIHByaW1heXIgcGxhbmUgZ2FtbWEKCnMvcHJpbWF5ci9wcmltYXJ5 LwoKPiBlbmFibGUgYml0IGFsc28gYWZmZWN0aW5nIHRoZSBwaXBlIGJvdHRvbSBjb2xvci4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgNTUg KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MyBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3Iu Ywo+IGluZGV4IDhkN2VhOTAyYTM0Yi4uYThiNzQyOGE2NGJmIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9jb2xvci5jCj4gQEAgLTYzMywyNyArNjMzLDc4IEBAIHZvaWQgaW50ZWxfY29sb3Jf Y29tbWl0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJZGV2 X3ByaXYtPmRpc3BsYXkuY29sb3JfY29tbWl0KGNydGNfc3RhdGUpOwo+ICB9Cj4gIAo+ICtzdGF0 aWMgYm9vbCBuZWVkX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICsJ CQkgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiArewo+ ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFz ZS5kZXYpOwo+ICsKPiArCS8qCj4gKwkgKiBPbiBwcmUtU0tMIHRoZSBwaXBlIGdhbW1hIGVuYWJs ZSBhbmQgcGlwZSBjc2MgZW5hYmxlIGZvcgo+ICsJICogdGhlIHBpcGUgYm90dG9tIGNvbG9yIGFy ZSBjb25maWd1cmVkIHZpYSB0aGUgcHJpbWFyeSBwbGFuZS4KPiArCSAqIFdlIGhhdmUgdG8gcmVj b25maWd1cmUgdGhhdCBldmVuIGlmIHRoZSBwbGFuZSBpcyBpbmFjdGl2ZS4KPiArCSAqLwo+ICsJ cmV0dXJuIGNydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgJiBCSVQocGxhbmUtPmlkKSB8fAo+ICsJ CShJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOSAmJgo+ICsJCSBwbGFuZS0+aWQgPT0gUExBTkVfUFJJ TUFSWSk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQKPiAraW50ZWxfY29sb3JfYWRkX2FmZmVjdGVk X3BsYW5lcyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUpCj4gK3sKPiAr CXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhuZXdfY3J0Y19zdGF0ZS0+ YmFzZS5jcnRjKTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUg PQo+ICsJCXRvX2ludGVsX2F0b21pY19zdGF0ZShuZXdfY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZSk7 Cj4gKwljb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUgPQo+ICsJ CWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ICsJc3RydWN0 IGludGVsX3BsYW5lICpwbGFuZTsKPiArCj4gKwlpZiAobmV3X2NydGNfc3RhdGUtPmdhbW1hX2Vu YWJsZSA9PSBvbGRfY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlKQo+ICsJCXJldHVybiAwOwo+ICsK PiArCWZvcl9lYWNoX2ludGVsX3BsYW5lX29uX2NydGMoJmRldl9wcml2LT5kcm0sIGNydGMsIHBs YW5lKSB7Cj4gKwkJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4g KwkJaWYgKCFuZWVkX3BsYW5lX3VwZGF0ZShwbGFuZSwgbmV3X2NydGNfc3RhdGUpKQo+ICsJCQlj b250aW51ZTsKPiArCj4gKwkJcGxhbmVfc3RhdGUgPSBpbnRlbF9hdG9taWNfZ2V0X3BsYW5lX3N0 YXRlKHN0YXRlLCBwbGFuZSk7Cj4gKwkJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkpCj4gKwkJCXJl dHVybiBQVFJfRVJSKHBsYW5lX3N0YXRlKTsKPiArCj4gKwkJbmV3X2NydGNfc3RhdGUtPnVwZGF0 ZV9wbGFuZXMgfD0gQklUKHBsYW5lLT5pZCk7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30K PiArCj4gIGludCBpbnRlbF9jb2xvcl9jaGVjayhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0 Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX3By b3BlcnR5X2Jsb2IgKmdhbW1hX2x1dCA9IGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0Owo+ICAJ Y29uc3Qgc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpkZWdhbW1hX2x1dCA9IGNydGNfc3RhdGUt PmJhc2UuZGVnYW1tYV9sdXQ7Cj4gIAlzaXplX3QgZ2FtbWFfbGVuZ3RoLCBkZWdhbW1hX2xlbmd0 aDsKPiArCWludCByZXQ7Cj4gIAo+ICAJZGVnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZPKGRldl9w cml2KS0+Y29sb3IuZGVnYW1tYV9sdXRfc2l6ZTsKPiAgCWdhbW1hX2xlbmd0aCA9IElOVEVMX0lO Rk8oZGV2X3ByaXYpLT5jb2xvci5nYW1tYV9sdXRfc2l6ZTsKPiAgCj4gLQljcnRjX3N0YXRlLT5n YW1tYV9lbmFibGUgPSB0cnVlOwo+ICsJY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlID0gZ2FtbWFf bHV0IHx8IGRlZ2FtbWFfbHV0Owo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkg fHwKPiAgCSAgICBJU19CUk9BRFdFTEwoZGV2X3ByaXYpIHx8IElTX0hBU1dFTEwoZGV2X3ByaXYp KQo+ICAJCWNydGNfc3RhdGUtPmNzY19lbmFibGUgPSB0cnVlOwo+ICAKPiArCXJldCA9IGludGVs X2NvbG9yX2FkZF9hZmZlY3RlZF9wbGFuZXMoY3J0Y19zdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ICsJ CXJldHVybiByZXQ7Cj4gKwo+ICAJLyoKPiAgCSAqIFdlIGFsc28gYWxsb3cgbm8gZGVnYW1tYSBs dXQvY3RtIGFuZCBhIGdhbW1hIGx1dCBhdCB0aGUgbGVnYWN5Cj4gIAkgKiBzaXplICgyNTYgZW50 cmllcykuCj4gIAkgKi8KPiAtCWlmIChjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0 YXRlKSkgewo+ICsJaWYgKCFjcnRjX3N0YXRlLT5nYW1tYV9lbmFibGUgfHwKPiArCSAgICBjcnRj X3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0YXRlKSkgewo+ICAJCWNydGNfc3RhdGUtPmdh bW1hX21vZGUgPSBHQU1NQV9NT0RFX01PREVfOEJJVDsKCklmIG5vbmUgb2Ygb3VyIHBsYW5lcyBh cmUgYWN0dWFsbHkgdXNpbmcgdGhlIGdhbW1hLCB3aGF0IGRvZXMgc3dpdGNoaW5nCmJhY2sgdG8g OGJpdCBtb2RlIGRvIGZvciB1cz8KClJlZ2FyZGxlc3MsCgpSZXZpZXdlZC1ieTogTWF0dCBSb3Bl ciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KCgo+ICAJCXJldHVybiAwOwo+ICAJfQo+IC0t IAo+IDIuMTkuMgo+IAoKLS0gCk1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIK SW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5 MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=