From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/3] crypto: set CRYPTO_TFM_NEED_KEY if ->setkey() fails
Date: Fri, 18 Jan 2019 18:55:36 +0800 [thread overview]
Message-ID: <20190118105536.4i4xwqindoqh2wex@gondor.apana.org.au> (raw)
In-Reply-To: <20190107024744.4952-1-ebiggers@kernel.org>
On Sun, Jan 06, 2019 at 06:47:41PM -0800, Eric Biggers wrote:
> This series makes the crypto API mark shash, ahash, skcipher, and aead
> tfms as needing a key again if setting a key fails, since on failure
> many algorithms can leave the tfm in an intermediate state that is
> neither the old key nor the new key -- and use of such tfms for hashing,
> encryption, or decryption will produce bogus results or crashes.
>
> Eric Biggers (3):
> crypto: hash - set CRYPTO_TFM_NEED_KEY if ->setkey() fails
> crypto: skcipher - set CRYPTO_TFM_NEED_KEY if ->setkey() fails
> crypto: aead - set CRYPTO_TFM_NEED_KEY if ->setkey() fails
>
> crypto/aead.c | 4 +++-
> crypto/ahash.c | 28 +++++++++++++++++++---------
> crypto/shash.c | 18 +++++++++++++-----
> crypto/skcipher.c | 27 ++++++++++++++++++---------
> 4 files changed, 53 insertions(+), 24 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-01-18 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 2:47 [PATCH 0/3] crypto: set CRYPTO_TFM_NEED_KEY if ->setkey() fails Eric Biggers
2019-01-07 2:47 ` [PATCH 1/3] crypto: hash - " Eric Biggers
2019-01-07 2:47 ` [PATCH 2/3] crypto: skcipher " Eric Biggers
2019-01-07 2:47 ` [PATCH 3/3] crypto: aead " Eric Biggers
2019-01-18 10:55 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118105536.4i4xwqindoqh2wex@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.