From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@arm.com>
Date: Fri, 18 Jan 2019 11:53:49 +0000
Subject: [U-Boot] [PATCH v2 0/7] mmc: sunxi: Enable DM_MMC
In-Reply-To: <20190117170951.23623-1-jagan@amarulasolutions.com>
References: <20190117170951.23623-1-jagan@amarulasolutions.com>
Message-ID: <20190118113335.4cf300d2@donnerap.cambridge.arm.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 17 Jan 2019 22:39:44 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:

> V2 for previous version[1] changes, for enabling DM_MMC
> on Allwinner platform.

So this is a neat and simple solution to the DM_MMC problem, to the
point where I am wondering why we actually need all those DT driven
clock and reset drivers in the first place.
But as I understand using plat data in this way is somewhat frowned
upon and considered deprecated (although it makes a lot of sense in
this context).

Also, isn't this series independent from the clock gates/reset
patches? So why do you pile them on top of each other in sunxi/next?

If we really want to have the full featured DT driven clock and reset
support, why not use it together:
We keep the current mod clock support in the MMC driver, but use the
newly introduced clock gates and reset support via the new clock
driver, mostly replacing this series. This would give us some test
coverage of the new clock driver, while still avoiding to rush the MMC
mod clock implementation.

Does that make sense? Happy to bake some patches for that on the
weekend.

Btw: After talking to Tom on IRC, the DM_MMC deadline is actually
_after_ the 2019.04 release, so we don't need to have DM_MMC support in
this merge window.

Cheers,
Andre.

> Changes for v2:
> - update the 'reset enablement' logic to do
>   required SoC's
> 
> Note: All changes available at u-boot-sunxi/next	
> 
> [1] https://patchwork.ozlabs.org/cover/1023710/
> 
> Any comments?
> Jagan.
> 
> Jagan Teki (7):
>   mmc: sunxi: Configure reset support for DM_MMC
>   mmc: sunxi: Add A83T emmc compatible
>   mmc: sunxi: Add mmc, emmc H5/A64 compatible
>   mmc: sunxi: Add DM_MMC support for H6
>   mmc: sunxi: Add DM_MMC support for A80
>   arm: sunxi: Enable DM_MMC
>   arm: dts: sunxi: Enumerate MMC2 as MMC1
> 
>  arch/arm/Kconfig                              |  1 +
>  arch/arm/dts/sunxi-u-boot.dtsi                |  4 +
>  .../include/asm/arch-sunxi/clock_sun50i_h6.h  |  3 +
>  arch/arm/mach-sunxi/Kconfig                   |  1 -
>  configs/Linksprite_pcDuino3_defconfig         |  1 -
>  drivers/mmc/sunxi_mmc.c                       | 73
> ++++++++++++++++++- 6 files changed, 79 insertions(+), 4 deletions(-)
>