From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B64C43387 for ; Fri, 18 Jan 2019 14:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 391C62087E for ; Fri, 18 Jan 2019 14:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nucleusys.com header.i=@nucleusys.com header.b="JxplSFXs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727729AbfARO5O (ORCPT ); Fri, 18 Jan 2019 09:57:14 -0500 Received: from lan.nucleusys.com ([92.247.61.126]:60652 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727406AbfARO5N (ORCPT ); Fri, 18 Jan 2019 09:57:13 -0500 X-Greylist: delayed 1609 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Jan 2019 09:57:13 EST DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nucleusys.com; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5c7eOhj4YaiPH4wUqs+wk0Plpt5+mmDlev9fnzeSKTU=; b=JxplSFXs5VwncpgoVAERrq8z9l nFdEQXrk0j5QyGuSGi3yPsEpsxR0jSyOYGU1BBpqOUWbuMcmvSVpsZ7+I1+EzJY+15OtSSLFA64Ro N7UcOEycx+O3Gza0q8RpJy5s1swVWWT9jMzwv5Yrooaa/O6geqfNJqVfp2k2GuRBtOXw=; Received: from [92.247.152.151] (helo=p310) by zztop.nucleusys.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gkVA0-000333-K6; Fri, 18 Jan 2019 16:30:17 +0200 Date: Fri, 18 Jan 2019 16:30:21 +0200 From: Petko Manolov To: YueHaibing Cc: "David S. Miller" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' Message-ID: <20190118143021.GJ29272@p310> References: <1547777209-92367-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547777209-92367-1-git-send-email-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 19-01-18 02:06:49, YueHaibing wrote: > From: Yue Haibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/rtl8150.c: In function 'read_bulk_callback': > drivers/net/usb/rtl8150.c:391:6: warning: > variable 'rx_stat' set but not used [-Wunused-but-set-variable] Good catch, thanks. Petko > Signed-off-by: Yue Haibing > --- > drivers/net/usb/rtl8150.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index 80373a9..3f145e4 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c > @@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb) > unsigned pkt_len, res; > struct sk_buff *skb; > struct net_device *netdev; > - u16 rx_stat; > int status = urb->status; > int result; > unsigned long flags; > @@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb) > goto goon; > > res = urb->actual_length; > - rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4)); > pkt_len = res - 4; > > skb_put(dev->rx_skb, pkt_len); > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petko Manolov Date: Fri, 18 Jan 2019 14:30:21 +0000 Subject: Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' Message-Id: <20190118143021.GJ29272@p310> List-Id: References: <1547777209-92367-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1547777209-92367-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: "David S. Miller" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 19-01-18 02:06:49, YueHaibing wrote: > From: Yue Haibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/rtl8150.c: In function 'read_bulk_callback': > drivers/net/usb/rtl8150.c:391:6: warning: > variable 'rx_stat' set but not used [-Wunused-but-set-variable] Good catch, thanks. Petko > Signed-off-by: Yue Haibing > --- > drivers/net/usb/rtl8150.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index 80373a9..3f145e4 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c > @@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb) > unsigned pkt_len, res; > struct sk_buff *skb; > struct net_device *netdev; > - u16 rx_stat; > int status = urb->status; > int result; > unsigned long flags; > @@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb) > goto goon; > > res = urb->actual_length; > - rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4)); > pkt_len = res - 4; > > skb_put(dev->rx_skb, pkt_len); > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' From: Petko Manolov Message-Id: <20190118143021.GJ29272@p310> Date: Fri, 18 Jan 2019 16:30:21 +0200 To: YueHaibing Cc: "David S. Miller" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gMTktMDEtMTggMDI6MDY6NDksIFl1ZUhhaWJpbmcgd3JvdGU6Cj4gRnJvbTogWXVlIEhhaWJp bmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4KPiAKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1z ZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4gZHJpdmVycy9uZXQvdXNiL3J0bDgxNTAuYzogSW4g ZnVuY3Rpb24gJ3JlYWRfYnVsa19jYWxsYmFjayc6Cj4gZHJpdmVycy9uZXQvdXNiL3J0bDgxNTAu YzozOTE6Njogd2FybmluZzoKPiAgdmFyaWFibGUgJ3J4X3N0YXQnIHNldCBidXQgbm90IHVzZWQg Wy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCgpHb29kIGNhdGNoLCB0aGFua3MuCgoKCQlQZXRr bwoKCj4gU2lnbmVkLW9mZi1ieTogWXVlIEhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9uZXQvdXNiL3J0bDgxNTAuYyB8IDIgLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3VzYi9ydGw4 MTUwLmMgYi9kcml2ZXJzL25ldC91c2IvcnRsODE1MC5jCj4gaW5kZXggODAzNzNhOS4uM2YxNDVl NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC91c2IvcnRsODE1MC5jCj4gKysrIGIvZHJpdmVy cy9uZXQvdXNiL3J0bDgxNTAuYwo+IEBAIC0zODgsNyArMzg4LDYgQEAgc3RhdGljIHZvaWQgcmVh ZF9idWxrX2NhbGxiYWNrKHN0cnVjdCB1cmIgKnVyYikKPiAgCXVuc2lnbmVkIHBrdF9sZW4sIHJl czsKPiAgCXN0cnVjdCBza19idWZmICpza2I7Cj4gIAlzdHJ1Y3QgbmV0X2RldmljZSAqbmV0ZGV2 Owo+IC0JdTE2IHJ4X3N0YXQ7Cj4gIAlpbnQgc3RhdHVzID0gdXJiLT5zdGF0dXM7Cj4gIAlpbnQg cmVzdWx0Owo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiBAQCAtNDI0LDcgKzQyMyw2IEBAIHN0 YXRpYyB2b2lkIHJlYWRfYnVsa19jYWxsYmFjayhzdHJ1Y3QgdXJiICp1cmIpCj4gIAkJZ290byBn b29uOwo+ICAKPiAgCXJlcyA9IHVyYi0+YWN0dWFsX2xlbmd0aDsKPiAtCXJ4X3N0YXQgPSBsZTE2 X3RvX2NwdSgqKF9fbGUxNiAqKSh1cmItPnRyYW5zZmVyX2J1ZmZlciArIHJlcyAtIDQpKTsKPiAg CXBrdF9sZW4gPSByZXMgLSA0Owo+ICAKPiAgCXNrYl9wdXQoZGV2LT5yeF9za2IsIHBrdF9sZW4p Owo+IAo+IAo+IAo+Cg==