All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Clark Williams <williams@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Networking Development Mailing List 
	<netdev@vger.kernel.org>
Subject: Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event_open()
Date: Fri, 18 Jan 2019 17:19:59 +0100	[thread overview]
Message-ID: <20190118161959.GI14054@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20190118150938.GN5823@kernel.org>

On Fri, Jan 18, 2019 at 12:09:38PM -0300, Arnaldo Carvalho de Melo wrote:
> commit 1b3b3dee572d0b77a316ab6715091201be6832de
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date:   Fri Jan 11 13:20:20 2019 -0300
> 
>     perf: Make perf_event_output() propagate the output() return
>     
>     For the original mode of operation it isn't needed, since we report back
>     errors via PERF_RECORD_LOST records in the ring buffer, but for use in
>     bpf_perf_event_output() it is convenient to return the errors, basically
>     -ENOSPC.
>     
>     Currently bpf_perf_event_output() returns an error indication, the last
>     thing it does, which is to push it to the ring buffer is that can fail
>     and if so, this failure won't be reported back to its users, fix it.
>     
>     Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
>     Tested-by: Jamal Hadi Salim <jhs@mojatatu.com>
>     Cc: Adrian Hunter <adrian.hunter@intel.com>
>     Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
>     Cc: Daniel Borkmann <daniel@iogearbox.net>
>     Cc: Jiri Olsa <jolsa@kernel.org>
>     Cc: Namhyung Kim <namhyung@kernel.org>
>     Cc: Peter Zijlstra <peterz@infradead.org>
>     Link: https://lkml.kernel.org/r/20190111155538.GX22483@kernel.org
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

/me hates on git-format :-)

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>


  reply	other threads:[~2019-01-18 16:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 15:55 Arnaldo Carvalho de Melo
2019-01-11 15:55 ` Arnaldo Carvalho de Melo
2019-01-12 13:59 ` Jamal Hadi Salim
2019-01-12 13:59   ` Jamal Hadi Salim
2019-01-18 14:52 ` Peter Zijlstra
2019-01-18 15:09   ` Arnaldo Carvalho de Melo
2019-01-18 16:19     ` Peter Zijlstra [this message]
2019-01-22 10:17     ` [tip:perf/core] perf: Make perf_event_output() propagate the output() return tip-bot for Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118161959.GI14054@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=jhs@mojatatu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=williams@redhat.com \
    --subject='Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event_open()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.