All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] mmc: sunxi: Mark end of DM_MMC #ifdefs
Date: Sat, 19 Jan 2019 01:30:55 +0000	[thread overview]
Message-ID: <20190119013055.28023-10-andre.przywara@arm.com> (raw)
In-Reply-To: <20190119013055.28023-1-andre.przywara@arm.com>

The Allwinner MMC supports both the legacy approach and the driver model,
at the cost of quite some #ifdefs.

Mark the closing #endifs with their respective config symbol, to make it
more obvious where each part ends and begins.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 drivers/mmc/sunxi_mmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index 374775194d..ee0bc9da89 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -104,7 +104,7 @@ static int mmc_resource_init(int sdc_no)
 
 	return ret;
 }
-#endif
+#endif	/* !DM_MMC */
 
 static int mmc_set_mod_clk(struct sunxi_mmc_priv *priv, unsigned int hz)
 {
@@ -566,7 +566,7 @@ struct mmc *sunxi_mmc_init(int sdc_no)
 
 	return mmc_create(cfg, priv);
 }
-#else
+#else	/* DM_MMC */
 
 static int sunxi_mmc_set_ios(struct udevice *dev)
 {
@@ -747,4 +747,4 @@ U_BOOT_DRIVER(sunxi_mmc_drv) = {
 	.platdata_auto_alloc_size = sizeof(struct sunxi_mmc_plat),
 	.priv_auto_alloc_size = sizeof(struct sunxi_mmc_priv),
 };
-#endif
+#endif	/* DM_MMC */
-- 
2.14.5

  parent reply	other threads:[~2019-01-19  1:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19  1:30 [U-Boot] [PATCH 0/9] sunxi: enable DM_MMC Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 1/9] sunxi: clk: add MMC gates/resets Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 2/9] sunxi: clk: A80: add MMC clock support Andre Przywara
2019-01-21  9:31   ` [U-Boot] [linux-sunxi] " Jagan Teki
2019-01-21  9:34     ` Chen-Yu Tsai
2019-01-21  9:38       ` Andre Przywara
2019-01-21 10:02         ` Chen-Yu Tsai
2019-01-21 10:12           ` Andre Przywara
2019-01-21 10:29             ` Chen-Yu Tsai
2019-01-19  1:30 ` [U-Boot] [PATCH 3/9] mmc: sunxi: Add DM clk and reset support Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 4/9] mmc: sunxi: Add H6 support Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 5/9] mmc: sunxi: Add missing compatible strings Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 6/9] mmc: sunxi: Add A80 support Andre Przywara
2019-01-19  1:30 ` [U-Boot] [PATCH 7/9] mmc: sunxi: Honour non-removable property in DT Andre Przywara
2019-01-25  7:16   ` [U-Boot] [linux-sunxi] " Jagan Teki
2019-01-25  9:28     ` Andre Przywara
2019-01-29 18:20   ` Jagan Teki
2019-01-19  1:30 ` [U-Boot] [PATCH 8/9] arm: sunxi: Enable DM_MMC Andre Przywara
2019-01-31 10:04   ` Simon Glass
2019-01-19  1:30 ` Andre Przywara [this message]
2019-01-31 10:04   ` [U-Boot] [PATCH 9/9] mmc: sunxi: Mark end of DM_MMC #ifdefs Simon Glass
2019-01-31 14:55     ` Andre Przywara
2019-01-19 18:32 ` [U-Boot] [PATCH 0/9] sunxi: enable DM_MMC Vasily Khoruzhick
2019-01-19 20:33   ` André Przywara
2019-01-19 23:42     ` Vasily Khoruzhick
2019-01-20 19:51 ` [U-Boot] [linux-sunxi] " Priit Laes
2019-01-21  0:54   ` André Przywara
2019-01-21  8:22     ` Priit Laes
2019-01-21  8:51       ` Andre Przywara
2019-01-21  9:10         ` Priit Laes
2019-01-22  9:49     ` Lukasz Majewski
2019-01-21  9:22 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190119013055.28023-10-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.