From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support Date: Sun, 20 Jan 2019 09:28:45 +0100 Message-ID: <20190120082845.4apq3ylk4i6zbhlx@verge.net.au> References: <1547663874-29411-1-git-send-email-fabrizio.castro@bp.renesas.com> <1547663874-29411-8-git-send-email-fabrizio.castro@bp.renesas.com> <20190117115945.bmlaoeoqvsmdqqot@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Fabrizio Castro Cc: Rob Herring , Mark Rutland , Wolfgang Grandegger , Marc Kleine-Budde , Michael Turquette , Stephen Boyd , Biju Das , Magnus Damm , "David S. Miller" , Geert Uytterhoeven , Thierry Reding , Andreas =?utf-8?Q?F=C3=A4rber?= , Alexandre Belloni , Kevin Hilman , Johan Hovold , Lukasz Majewski , Michal Simek , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Martin Blumenstingl List-Id: linux-can.vger.kernel.org On Thu, Jan 17, 2019 at 01:27:51PM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback! > > > From: Simon Horman > > Sent: 17 January 2019 12:00 > > Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support > > > > On Wed, Jan 16, 2019 at 06:37:50PM +0000, Fabrizio Castro wrote: > > > From: Biju Das > > > > > > This patch adds ethernet support to the sub board. > > > > > > Signed-off-by: Biju Das > > > Signed-off-by: Fabrizio Castro > > > Reviewed-by: Chris Paterson > > > --- > > > arch/arm64/boot/dts/renesas/cat875.dtsi | 30 ++++++++++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi > > > index a41d0d8..805ffa7 100644 > > > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi > > > @@ -7,4 +7,34 @@ > > > > > > / { > > > model = "Silicon Linux sub board for CAT874 (CAT875)"; > > > + > > > +aliases { > > > +ethernet0 = &avb; > > > +}; > > > +}; > > > + > > > +&avb { > > > +pinctrl-0 = <&avb_pins>; > > > +pinctrl-names = "default"; > > > +renesas,no-ether-link; > > > > Is the renesas,no-ether-link required? > > The AVB_LINK pin from the SoC is connected to the PMEB (Power Management Event, B stands for > active low) pin on the PHY, which means it is not a link signal. The PMEB signal is active when a magic > packet or a wake up frame are detected. As a result, we need renesas,no-ether-link and we can't > specify avb_link with avb_pin either. Thanks for following-up. In that case I am fine with this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9780C6369F for ; Sun, 20 Jan 2019 08:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9851C2084C for ; Sun, 20 Jan 2019 08:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="rZzZxQ39" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730184AbfATI2y (ORCPT ); Sun, 20 Jan 2019 03:28:54 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:53640 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727294AbfATI2x (ORCPT ); Sun, 20 Jan 2019 03:28:53 -0500 Received: from penelope.horms.nl (ip4dab7138.direct-adsl.nl [77.171.113.56]) by kirsty.vergenet.net (Postfix) with ESMTPA id 7F5FA25B7C3; Sun, 20 Jan 2019 19:28:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1547972928; bh=5RexUjBAwg0AMz6MJICuwvD/q9yN9IG8PuNoE1lhSAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rZzZxQ39Tvoxvujb8hB0gKLRCoUQj7QhpOzqb1+d64SGGt/jr64dvMBTxG+RJvtyd Ox0DE3pOLHGlQUcqr7wNMKfiFMN9v19kRvyU4zVKe6l6/w60L52RzM6F4Fb46TJPFG yLuHIhTHNrp6dYCo+N/Babg8/+8yTeWmrukecjTk= Received: by penelope.horms.nl (Postfix, from userid 7100) id 826FFE21E4A; Sun, 20 Jan 2019 09:28:45 +0100 (CET) Date: Sun, 20 Jan 2019 09:28:45 +0100 From: Simon Horman To: Fabrizio Castro Cc: Rob Herring , Mark Rutland , Wolfgang Grandegger , Marc Kleine-Budde , Michael Turquette , Stephen Boyd , Biju Das , Magnus Damm , "David S. Miller" , Geert Uytterhoeven , Thierry Reding , Andreas =?utf-8?Q?F=C3=A4rber?= , Alexandre Belloni , Kevin Hilman , Johan Hovold , Lukasz Majewski , Michal Simek , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Martin Blumenstingl , Ben Whitten , Chris Paterson , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , "ebiharaml@si-linux.co.jp" Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support Message-ID: <20190120082845.4apq3ylk4i6zbhlx@verge.net.au> References: <1547663874-29411-1-git-send-email-fabrizio.castro@bp.renesas.com> <1547663874-29411-8-git-send-email-fabrizio.castro@bp.renesas.com> <20190117115945.bmlaoeoqvsmdqqot@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 17, 2019 at 01:27:51PM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback! > > > From: Simon Horman > > Sent: 17 January 2019 12:00 > > Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support > > > > On Wed, Jan 16, 2019 at 06:37:50PM +0000, Fabrizio Castro wrote: > > > From: Biju Das > > > > > > This patch adds ethernet support to the sub board. > > > > > > Signed-off-by: Biju Das > > > Signed-off-by: Fabrizio Castro > > > Reviewed-by: Chris Paterson > > > --- > > > arch/arm64/boot/dts/renesas/cat875.dtsi | 30 ++++++++++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi > > > index a41d0d8..805ffa7 100644 > > > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi > > > @@ -7,4 +7,34 @@ > > > > > > / { > > > model = "Silicon Linux sub board for CAT874 (CAT875)"; > > > + > > > +aliases { > > > +ethernet0 = &avb; > > > +}; > > > +}; > > > + > > > +&avb { > > > +pinctrl-0 = <&avb_pins>; > > > +pinctrl-names = "default"; > > > +renesas,no-ether-link; > > > > Is the renesas,no-ether-link required? > > The AVB_LINK pin from the SoC is connected to the PMEB (Power Management Event, B stands for > active low) pin on the PHY, which means it is not a link signal. The PMEB signal is active when a magic > packet or a wake up frame are detected. As a result, we need renesas,no-ether-link and we can't > specify avb_link with avb_pin either. Thanks for following-up. In that case I am fine with this patch.