From: Lubomir Rintel <lkundrak@v3.sk>
To: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>
Cc: Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Lubomir Rintel <lkundrak@v3.sk>
Subject: [PATCH 2/6] dt-bindings: display: armada: Improve the LCDC documentation
Date: Sun, 20 Jan 2019 18:25:30 +0100 [thread overview]
Message-ID: <20190120172534.24617-3-lkundrak@v3.sk> (raw)
In-Reply-To: <20190120172534.24617-1-lkundrak@v3.sk>
The port is a child, not a property. And it deserves an example.
Also, make the title a bit more visually distinguishable -- this will
look better when the documentation of other Adrmada DRM nodes will be
present.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
.../display/armada/marvell-armada-drm.txt | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
index 46525ea3e646..2606a8efc956 100644
--- a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
+++ b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
@@ -1,10 +1,11 @@
-Device Tree bindings for Armada DRM CRTC driver
+Marvell Armada LCD controller
+=============================
Required properties:
+
- compatible: value should be "marvell,dove-lcd".
- reg: base address and size of the LCD controller
- interrupts: single interrupt number for the LCD controller
- - port: video output port with endpoints, as described by graph.txt
Optional properties:
@@ -19,6 +20,11 @@ Note: all clocks are optional but at least one must be specified.
Further clocks may be added in the future according to requirements of
different SoCs.
+Required child nodes:
+
+- port: video output port with endpoints, as described by
+ Documentation/devicetree/bindings/graph.txt
+
Example:
lcd0: lcd-controller@820000 {
@@ -27,4 +33,10 @@ Example:
interrupts = <47>;
clocks = <&si5351 0>;
clock-names = "ext_ref_clk_1";
+
+ lcd0_port: port {
+ lcd0_rgb_out: endpoint {
+ remote-endpoint = <&encoder_rgb_in>;
+ };
+ };
};
--
2.20.1
next prev parent reply other threads:[~2019-01-20 17:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 17:25 [PATCH 0/6] Bindings for Armada display subsystem Lubomir Rintel
2019-01-20 17:25 ` [PATCH 1/6] dt-bindings: display: armada: Rename the binding doc file Lubomir Rintel
2019-01-20 17:25 ` Lubomir Rintel [this message]
2019-01-20 17:25 ` [PATCH 3/6] dt-bindings: display: armada: Add framebuffer reserved-mem binding Lubomir Rintel
2019-01-20 17:25 ` [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding Lubomir Rintel
2019-01-21 15:35 ` Rob Herring
2019-01-21 15:46 ` Lubomir Rintel
2019-01-21 16:07 ` Rob Herring
2019-01-21 17:53 ` Russell King - ARM Linux admin
2019-01-21 20:45 ` Lubomir Rintel
2019-01-21 23:08 ` Russell King - ARM Linux admin
2019-01-21 23:08 ` Russell King - ARM Linux admin
2019-01-21 23:58 ` Rob Herring
2019-01-22 10:58 ` Russell King - ARM Linux admin
2019-01-22 10:58 ` Russell King - ARM Linux admin
2019-01-22 16:06 ` Rob Herring
2019-02-13 22:37 ` Lubomir Rintel
2019-02-22 20:23 ` Rob Herring
2019-02-24 16:15 ` Lubomir Rintel
2019-03-04 17:35 ` Rob Herring
2019-03-04 17:35 ` Rob Herring
2019-01-20 17:25 ` [PATCH 5/6] dt-bindings: display: armada: Add mmp2 compatible strings Lubomir Rintel
2019-01-20 17:25 ` [PATCH 6/6] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120172534.24617-3-lkundrak@v3.sk \
--to=lkundrak@v3.sk \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.