From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C811C282F6 for ; Mon, 21 Jan 2019 09:11:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D543214DA for ; Mon, 21 Jan 2019 09:11:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g9yPP0Xs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfAUJLQ (ORCPT ); Mon, 21 Jan 2019 04:11:16 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34703 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfAUJKz (ORCPT ); Mon, 21 Jan 2019 04:10:55 -0500 Received: by mail-lf1-f66.google.com with SMTP id p6so14961170lfc.1 for ; Mon, 21 Jan 2019 01:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=g9yPP0XsgTQaqbGubqKAK7/TayYb6NuHUCfzfkKlMkRKBPuOjiQLHJLQtC2+EWAqHR x1pucMKByNmMpEhYiKa+kisyX5Op9+QK6t/9GzlVX6X0bo7Kg5GhCw1shs70IbMqs1oC CS4+0croGN5v+Q24uPY1yx4747ONlNbvDsHCCI2bM8oW+zMUlt2o0fXd9yAhq7W5v/vW F4tIB4VRfBDrbYpGqnkdjG3EGbkhY8thP0HAE/xEruitJXUruxUNamLaenmV/KTcdSgR Q+jAuBbnrASAYa62NrvtYv+M7S/h78xjBkJrf8IGVevnyDZvxUE7Pty0YX+tU76R5VW8 YOGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tOSXZu5yZxn2uEqSYtv9bSchsaXMOBUmMRnB0hfrgZ4=; b=FJHGNps3H9psHIPxq+IMNUIx/TGfUByT19u9G3VhszKZYB+1mNBawWGq4XyGQ3IS2m ZKNq6FjKrgYsEQ0suOk+1y9Ucgyjj1pi0nctBmWJFer3w6GFRIv1LP/3X2DzozJuyq+o SWFx3Ag3d/mus+Z47NBvry6J1w329sC6p4xUrpfgtIkRds0Mj8uXDxR4F9mKU9W5UJnv hXSfzStmmt7MMymjB6doc9j05UJEoj6eBBA3Zw/Z03nMJhnqm/HmQuAoZKnPpeikT6WF 20V7LTmHLDaiAMZAhnEKVkNsLol0rI0Q3BKnhJ/8bCY2U/zaMAo3cBSd/6DkoRs9oaQK bLlg== X-Gm-Message-State: AJcUukcQKro3x0WLt0Z6ykeFX7PVKLxP/9ck6hsuUuqP74m4z6MTnLj7 CfzSSD43aMVGtFneg1vT/I4= X-Google-Smtp-Source: ALg8bN6wuJFAnkbrATxkgNlVdo7fsCznw80x1/PAT/ABEzQQBxFQAHi77dwqe6K2hN+QMNjL2OrFDA== X-Received: by 2002:a19:5402:: with SMTP id i2mr17523710lfb.128.1548061852069; Mon, 21 Jan 2019 01:10:52 -0800 (PST) Received: from localhost.localdomain (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id q128-v6sm2169147ljq.14.2019.01.21.01.10.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Jan 2019 01:10:51 -0800 (PST) From: Maciej Fijalkowski To: daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com Subject: [PATCH bpf-next v2 3/8] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Date: Mon, 21 Jan 2019 10:10:36 +0100 Message-Id: <20190121091041.14666-4-maciejromanfijalkowski@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20190121091041.14666-1-maciejromanfijalkowski@gmail.com> References: <20190121091041.14666-1-maciejromanfijalkowski@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer The sample xdp_redirect_cpu is not using helper bpf_trace_printk. Thus it makes no sense that the --debug option us reading from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. Simply remove it. Signed-off-by: Jesper Dangaard Brouer --- samples/bpf/xdp_redirect_cpu_user.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 100644 --- a/samples/bpf/xdp_redirect_cpu_user.c +++ b/samples/bpf/xdp_redirect_cpu_user.c @@ -51,7 +51,6 @@ static const struct option long_options[] = { {"help", no_argument, NULL, 'h' }, {"dev", required_argument, NULL, 'd' }, {"skb-mode", no_argument, NULL, 'S' }, - {"debug", no_argument, NULL, 'D' }, {"sec", required_argument, NULL, 's' }, {"prognum", required_argument, NULL, 'p' }, {"qsize", required_argument, NULL, 'q' }, @@ -563,7 +562,6 @@ int main(int argc, char **argv) bool use_separators = true; bool stress_mode = false; char filename[256]; - bool debug = false; int added_cpus = 0; int longindex = 0; int interval = 2; @@ -624,9 +622,6 @@ int main(int argc, char **argv) case 'S': xdp_flags |= XDP_FLAGS_SKB_MODE; break; - case 'D': - debug = true; - break; case 'x': stress_mode = true; break; @@ -688,11 +683,6 @@ int main(int argc, char **argv) return EXIT_FAIL_XDP; } - if (debug) { - printf("Debug-mode reading trace pipe (fix #define DEBUG)\n"); - read_trace_pipe(); - } - stats_poll(interval, use_separators, prog_num, stress_mode); return EXIT_OK; } -- 2.16.1