From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB186C282DB for ; Mon, 21 Jan 2019 09:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 705992084A for ; Mon, 21 Jan 2019 09:56:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="LTul5UcH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbfAUJ4E (ORCPT ); Mon, 21 Jan 2019 04:56:04 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:34052 "EHLO mail-wm1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbfAUJ4E (ORCPT ); Mon, 21 Jan 2019 04:56:04 -0500 Received: by mail-wm1-f42.google.com with SMTP id y185so5721713wmd.1 for ; Mon, 21 Jan 2019 01:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wlZRRahcLCsAvAtSbigTkSpBP7NgaIn8VZ9iPRwO63w=; b=LTul5UcHRMHELFtMYlBfpfUjn/LgSZTENnIiuKJtjrWA6N19JUU0nPxbwQLGRbslLg qyY1NBiBXKn5pE/lvnD8+zcynWhb0tPBX2Ez46Uot8uBEETeCEHvoA0U9xe8G4EXro2N qtxHk78nYdIExrv6xc+0ns/j08QHQnlZzFQAg/0LK2s2IG6I+8f7bgO57p5CuucTSxKo fzGdRBaTGzxgoGYfpR75OHHOh0HFeD7qzHD3yv7/SvfBLr2bvjhwUmgkxgUQm8Z3bmTp 4xsAAMdxjuC+4YxVSnTqUU3TkAz+Uh9+eaogXUlpPFzVzTEGFkFjWiOBZ2QPc3UCkpTk biHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wlZRRahcLCsAvAtSbigTkSpBP7NgaIn8VZ9iPRwO63w=; b=FcIHY3CX7bKB5pJkDUCmsK12MslDwBtXf6R+Lcw9759HBlS6sGK8blmGdtPGyhmfuu U9zffS5VjPWBZaiwp4ckujlyV9Q0ZwmislzsNNDxO064WLrYYlCzNVt3kZsI6QVTqoFc YZp7uvkTlLRe6pycMROdNoFr4IP9T81T6lc5Yadb8G8mB/5xZxQI0hcgzzfWpsaRb3mX 2gNPV4Tjzn4ifHhkMDGLv08P+5e50eIPBHHifuc0rTte70spu8C2n4lVUs8z8+cSJkGV LkBw+yfTUSl+HKPI2++Ld8i7DsVZHIYkm0PAxp4MWjT6orMXqMVAMZXt+4J7LNHdoYLw GjBw== X-Gm-Message-State: AJcUukcFcpR+ON6Zx3MPSdMrQ5PaILfstoQ2HkHMbPW+NCyuPyfxvyGv AasgDydXIs9Eqgzk8lMPErYMLg== X-Google-Smtp-Source: ALg8bN76Ibukwn5aE6fUzoA7dcAcFCXlKmSv24E9Frx7CQ9MsWLOHz/JzXkLiXIAEocC6HmKD7d/yw== X-Received: by 2002:a1c:f207:: with SMTP id s7mr23565682wmc.87.1548064562279; Mon, 21 Jan 2019 01:56:02 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id q14sm73850897wrw.39.2019.01.21.01.56.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 01:56:00 -0800 (PST) Date: Mon, 21 Jan 2019 10:47:16 +0100 From: Jiri Pirko To: Sven Eckelmann Cc: b.a.t.m.a.n@lists.open-mesh.org, Jiri Pirko , netdev@vger.kernel.org Subject: Re: [RFC v4 00/19] batman-adv: netlink restructuring, part 2 Message-ID: <20190121094716.GD2228@nanopsycho> References: <20190119155626.6414-1-sven@narfation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190119155626.6414-1-sven@narfation.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Jan 19, 2019 at 04:56:07PM CET, sven@narfation.org wrote: >Hi, > >Jiri Pirko called the batman-adv configuration interface a while back "a >huge mistake" [1] and suggested genl as alternative. The first >reimplementation [2] (based on the team/devlink design) was rejected. This >second implementation is now using a nl80211-like design. The objects which >can now be modified/queried are: > >* mesh/soft-interface (BATADV_CMD_GET_MESH/BATADV_CMD_SET_MESH) >* slave/hard-interface (BATADV_CMD_GET_HARDIF/BATADV_CMD_SET_HARDIF) >* vlan (BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN) > >Such a set messages automatically triggers a *_SET_* "reply" via the config >multicast group. The same behavior was also added to the sysfs interface. In general aside of couple of nits I described, this iteration of the patchset looks very nice to me. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 21 Jan 2019 10:47:16 +0100 From: Jiri Pirko Message-ID: <20190121094716.GD2228@nanopsycho> References: <20190119155626.6414-1-sven@narfation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190119155626.6414-1-sven@narfation.org> Subject: Re: [B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2 List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sven Eckelmann Cc: b.a.t.m.a.n@lists.open-mesh.org, Jiri Pirko , netdev@vger.kernel.org Sat, Jan 19, 2019 at 04:56:07PM CET, sven@narfation.org wrote: >Hi, > >Jiri Pirko called the batman-adv configuration interface a while back "a >huge mistake" [1] and suggested genl as alternative. The first >reimplementation [2] (based on the team/devlink design) was rejected. This >second implementation is now using a nl80211-like design. The objects which >can now be modified/queried are: > >* mesh/soft-interface (BATADV_CMD_GET_MESH/BATADV_CMD_SET_MESH) >* slave/hard-interface (BATADV_CMD_GET_HARDIF/BATADV_CMD_SET_HARDIF) >* vlan (BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN) > >Such a set messages automatically triggers a *_SET_* "reply" via the config >multicast group. The same behavior was also added to the sysfs interface. In general aside of couple of nits I described, this iteration of the patchset looks very nice to me. Thanks!