From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org,
"Alex Williamson" <alex.williamson@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap
Date: Mon, 21 Jan 2019 10:53:14 +0000 [thread overview]
Message-ID: <20190121105314.GG30536@stefanha-x1.localdomain> (raw)
In-Reply-To: <64c2ec84-8950-3c58-0ca7-d54c1a9438d2@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Fri, Jan 18, 2019 at 12:14:14PM -0600, Eric Blake wrote:
> On 1/18/19 11:31 AM, Daniel P. Berrangé wrote:
> > +def c_macro_to_format(macro):
> > + if macro.startswith("PRI"):
> > + return macro[3]
> > +
> > + if macro == "TARGET_FMT_plx":
> > + return "%016x"
>
> Do we really want to permit TARGET_FMT in our trace-events files, or
> should that be fixed in hw/tpm/trace-events? See commit 73ff0610.
TARGET_FMT_plx is constant across all QEMU targets. I think supporting
it is nice since it makes writing trace events more natural/convenient.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2019-01-21 10:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 17:30 [Qemu-devel] [PATCH v2 0/4] trace: make systemtap easier to use for simple logging Daniel P. Berrangé
2019-01-18 17:31 ` [Qemu-devel] [PATCH v2 1/4] display: ensure qxl log_buf is a nul terminated string Daniel P. Berrangé
2019-01-18 17:40 ` Eric Blake
2019-01-18 17:42 ` Daniel P. Berrangé
2019-01-21 7:14 ` Gerd Hoffmann
2019-01-21 10:45 ` Stefan Hajnoczi
2019-01-22 14:17 ` Daniel P. Berrangé
2019-01-18 17:31 ` [Qemu-devel] [PATCH v2 2/4] trace: enforce that every trace-events file has a final newline Daniel P. Berrangé
2019-01-18 17:42 ` Eric Blake
2019-01-22 14:43 ` Daniel P. Berrangé
2019-01-21 10:47 ` Stefan Hajnoczi
2019-01-18 17:31 ` [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings Daniel P. Berrangé
2019-01-18 17:50 ` Eric Blake
2019-01-18 22:50 ` Alex Williamson
2019-01-22 14:32 ` Daniel P. Berrangé
2019-01-22 17:19 ` Eric Blake
2019-01-22 17:23 ` Daniel P. Berrangé
2019-01-22 18:10 ` Eric Blake
2019-10-18 9:31 ` Thomas Huth
2019-10-18 9:34 ` Daniel P. Berrangé
2019-01-18 17:31 ` [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap Daniel P. Berrangé
2019-01-18 18:14 ` Eric Blake
2019-01-21 10:53 ` Stefan Hajnoczi [this message]
2019-01-22 14:34 ` Daniel P. Berrangé
2019-01-22 14:39 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121105314.GG30536@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.