From: "Michael S. Tsirkin" <mst@redhat.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: Peng Fan <peng.fan@nxp.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC] virtio_ring: check dma_mem for xen_domain
Date: Mon, 21 Jan 2019 21:36:39 -0500 [thread overview]
Message-ID: <20190121213617-mutt-send-email-mst__40264.2021932238$1548124683$gmane$org@kernel.org> (raw)
In-Reply-To: <20190121082830.GC12420@infradead.org>
On Mon, Jan 21, 2019 at 12:28:30AM -0800, hch@infradead.org wrote:
> On Mon, Jan 21, 2019 at 04:51:57AM +0000, Peng Fan wrote:
> > on i.MX8QM, M4_1 is communicating with DomU using rpmsg with a fixed
> > address as the dma mem buffer which is predefined.
> >
> > Without this patch, the flow is:
> > vring_map_one_sg -> vring_use_dma_api
> > -> dma_map_page
> > -> __swiotlb_map_page
> > ->swiotlb_map_page
> > ->__dma_map_area(phys_to_virt(dma_to_phys(dev, dev_addr)), size, dir);
> > However we are using per device dma area for rpmsg, phys_to_virt
> > could not return a correct virtual address for virtual address in
> > vmalloc area. Then kernel panic.
>
> And that is the right thing to do. You must not call dma_map_* on
> memory that was allocated from dma_alloc_*.
>
> We actually have another thread which appears to be for this same issue.
Sorry, which thread do you refer to?
--
MST
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-22 2:37 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 4:51 [RFC] virtio_ring: check dma_mem for xen_domain Peng Fan
2019-01-21 4:51 ` Peng Fan
2019-01-21 4:51 ` Peng Fan
2019-01-21 8:28 ` hch
2019-01-21 8:28 ` hch
2019-01-21 8:28 ` hch
2019-01-22 2:32 ` Peng Fan
2019-01-22 2:32 ` Peng Fan
2019-01-22 2:32 ` Peng Fan
2019-01-22 2:36 ` Michael S. Tsirkin [this message]
2019-01-22 2:36 ` Michael S. Tsirkin
2019-01-22 2:36 ` Michael S. Tsirkin
2019-01-22 2:36 ` Michael S. Tsirkin
2019-01-21 8:28 ` hch
2019-01-22 19:59 ` Stefano Stabellini
2019-01-22 19:59 ` [Xen-devel] " Stefano Stabellini
2019-01-22 19:59 ` Stefano Stabellini
2019-01-23 2:57 ` Michael S. Tsirkin
2019-01-23 2:57 ` Michael S. Tsirkin
2019-01-23 2:57 ` [Xen-devel] " Michael S. Tsirkin
2019-01-23 2:57 ` Michael S. Tsirkin
2019-01-23 7:12 ` hch
2019-01-23 7:12 ` hch
2019-01-23 21:04 ` Stefano Stabellini
2019-01-23 21:04 ` [Xen-devel] " Stefano Stabellini
2019-01-23 21:04 ` Stefano Stabellini
2019-01-23 21:14 ` hch
2019-01-23 21:14 ` hch
2019-01-23 21:14 ` [Xen-devel] " hch
2019-01-23 21:14 ` hch
2019-01-23 23:43 ` Stefano Stabellini
2019-01-23 23:43 ` Stefano Stabellini
2019-01-24 6:47 ` Peng Fan
2019-01-24 6:47 ` [Xen-devel] " Peng Fan
2019-01-24 6:47 ` Peng Fan
2019-01-24 19:14 ` Stefano Stabellini
2019-01-24 19:14 ` [Xen-devel] " Stefano Stabellini
2019-01-24 19:14 ` Stefano Stabellini
2019-01-24 20:34 ` Michael S. Tsirkin
2019-01-24 20:34 ` Michael S. Tsirkin
2019-01-24 20:34 ` [Xen-devel] " Michael S. Tsirkin
2019-01-24 20:34 ` Michael S. Tsirkin
2019-01-23 23:43 ` Stefano Stabellini
2019-01-25 9:45 ` [Xen-devel] " Peng Fan
2019-01-25 9:45 ` Peng Fan
2019-01-25 19:18 ` Stefano Stabellini
2019-01-25 19:18 ` [Xen-devel] " Stefano Stabellini
2019-01-25 19:18 ` Stefano Stabellini
2019-01-28 8:00 ` hch
2019-01-28 8:00 ` [Xen-devel] " hch
2019-01-28 8:00 ` hch
2019-01-29 9:26 ` Peng Fan
2019-01-29 9:26 ` [Xen-devel] " Peng Fan
2019-01-29 9:26 ` Peng Fan
2019-01-28 8:00 ` hch
2019-01-25 9:45 ` Peng Fan
2019-01-23 7:12 ` [Xen-devel] " hch
2019-01-23 7:12 ` hch
2019-01-24 6:42 ` Peng Fan
2019-01-24 6:42 ` [Xen-devel] " Peng Fan
2019-01-24 6:42 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190121213617-mutt-send-email-mst__40264.2021932238$1548124683$gmane$org@kernel.org' \
--to=mst@redhat.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=sstabellini@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.